Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release/4.0.4 #1024

Merged
merged 5 commits into from
Nov 13, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 17 additions & 13 deletions cfn-templates/cid-cfn.yml
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
AWSTemplateFormatVersion: '2010-09-09'
Description: Deployment of Cloud Intelligence Dashboards v4.0.3
Description: Deployment of Cloud Intelligence Dashboards v4.0.4
Metadata:
AWS::CloudFormation::Interface:
ParameterGroups:
Expand Down Expand Up @@ -655,17 +655,21 @@ Resources:
else:
return (True, f'ERROR: error invoking crawler {CRAWLER} {exc}')
print('started crawler started. waiting for crawler to finish')
start_time = time.time()
while time.time() - start_time < timeout_seconds:
time.sleep(10)
crawler_status = glue.get_crawler(Name=CRAWLER)['Crawler']['State']
print('status=', crawler_status)
if crawler_status in ('READY', 'STOPPING'):
print("Stop waiting")
break
else:
return (True, f"Timeout exceeded. Crawler '{CRAWLER}' did not complete. This is not a fatal error and the rest of the deployment will continue.")
try:
start_time = time.time()
while time.time() - start_time < timeout_seconds:
time.sleep(1)
crawler_status = glue.get_crawler(Name=CRAWLER)['Crawler']['State']
print(f'status = {crawler_status}')
if crawler_status in ('READY', 'STOPPING'):
print("Stop waiting")
break
else:
return (True, f"Timeout exceeded. Crawler '{CRAWLER}' did not complete. This is not a fatal error and the rest of the deployment will continue.")
iakov-aws marked this conversation as resolved.
Show resolved Hide resolved
except Exception as exc:
return (True, f'ERROR: error waiting for crawler {CRAWLER} {exc}')
return (True, 'Crawler run completed.')
return (True, 'Ended create.')

def on_delete():
# Delete bucket (CF cannot delete if they are non-empty)
Expand Down Expand Up @@ -869,7 +873,7 @@ Resources:
Path: !Ref RolePath
PermissionsBoundary: !If [NeedPermissionsBoundary, !Ref PermissionsBoundary, !Ref 'AWS::NoValue']
Policies:
- PolicyName: AWSCURCrawlerComponentFunction
- PolicyName: CloudWatch
PolicyDocument:
Version: 2012-10-17
Statement:
Expand Down Expand Up @@ -1777,7 +1781,7 @@ Resources:
- LambdaLayerBucketPrefixIsManaged
- !FindInMap [RegionMap, !Ref 'AWS::Region', BucketName]
- !Sub '${LambdaLayerBucketPrefix}-${AWS::Region}' # Region added for backward compatibility
S3Key: 'cid-resource-lambda-layer/cid-4.0.3.zip' #replace version here if needed
S3Key: 'cid-resource-lambda-layer/cid-4.0.4.zip' #replace version here if needed
CompatibleRuntimes:
- python3.10
- python3.11
Expand Down
2 changes: 1 addition & 1 deletion cid/_version.py
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
__version__ = '4.0.3'
__version__ = '4.0.4'

Loading