Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix default time columns #1030

Merged
merged 3 commits into from
Nov 16, 2024
Merged

fix default time columns #1030

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8b0616d
fix default time columns
iakov-aws Nov 14, 2024
c163139
release 4.0.5
iakov-aws Nov 15, 2024
df309fb
Merge branch 'release/4.0.5' into fix-default-time-cols
iakov-aws Nov 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions cfn-templates/cid-cfn.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
AWSTemplateFormatVersion: '2010-09-09'
Description: Deployment of Cloud Intelligence Dashboards v4.0.4
Description: Deployment of Cloud Intelligence Dashboards v4.0.5
Metadata:
AWS::CloudFormation::Interface:
ParameterGroups:
Expand Down Expand Up @@ -1781,7 +1781,7 @@ Resources:
- LambdaLayerBucketPrefixIsManaged
- !FindInMap [RegionMap, !Ref 'AWS::Region', BucketName]
- !Sub '${LambdaLayerBucketPrefix}-${AWS::Region}' # Region added for backward compatibility
S3Key: 'cid-resource-lambda-layer/cid-4.0.4.zip' #replace version here if needed
S3Key: 'cid-resource-lambda-layer/cid-4.0.5.zip' #replace version here if needed
CompatibleRuntimes:
- python3.10
- python3.11
Expand Down
2 changes: 1 addition & 1 deletion cid/_version.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
__version__ = '4.0.4'
__version__ = '4.0.5'

2 changes: 1 addition & 1 deletion cid/helpers/cur.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,7 +111,7 @@ def get_type_of_column(self, column: str, version=None):
if column.endswith('_date') and not column.endswith('_to_date'):
return 'TIMESTAMP'
if column.endswith('_time') and (version or self.version) == '2':
return 'TIMESTAMP'
return 'STRING' # yes, they are string
special_cases = {
"cost_category": "MAP",
"discount": "MAP",
Expand Down
Loading