Updates the Lambda function that creates the service-linked role for … #1053
+84
−42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…bcm-data-exports service
iakov-aws
requested changes
Dec 5, 2024
jaehyi-aws
commented
Dec 5, 2024
Comment on lines
738
to
740
| waiter = iam_client.get_waiter("role_exists") | ||
| waiter.wait(RoleName=role_name) | ||
| time.sleep(10) # Additional wait time, just in case |
There was a problem hiding this comment.
This ensures that the role is available after creation: https://boto3.amazonaws.com/v1/documentation/api/latest/reference/services/iam/waiter/RoleExists.html
…ig to set the max attempts to 30
jaehyi-aws
force-pushed
the
update-lambda-function-create-slr
branch
from
33367d4 to
3dbd5b5
Compare
iakov-aws
approved these changes
Dec 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:*
Description of changes:*
The
Timeoutfor the Lambda function was 15 seconds, which would not have been enough for the function to complete execution because of 30-second sleep in the code.ServiceTimeoutto the custom resource to match the function timeout.ListEnrollmentStatuses, instead ofGetPreferences, to check if an account is enrolled in COH.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.