Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove obsolete code #614

Merged
merged 2 commits into from
Sep 6, 2023
Merged

remove obsolete code #614

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fbc0982
remove obsolete code
iakov-aws Aug 30, 2023
89fe493
Merge branch 'main' into remove-override
iakov-aws Sep 5, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 0 additions & 17 deletions cid/common.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -502,23 +502,6 @@ def _deploy(self, dashboard_id: str=None, recursive=True, update=False, **kwargs
# Dashboard definition must contain names that are specific to template.
dashboard_definition['datasets'] = {ds_map.get(name, name): arn for name, arn in dashboard_definition['datasets'].items() }
logger.debug(f"datasets: {dashboard_definition['datasets']}")
#FIXME: this code looks absolete
kwargs = dict()
local_overrides = f'work/{self.base.account_id}/{dashboard_id}.json'
logger.info(f'Looking for local overrides file "{local_overrides}"...')
try:
with open(local_overrides, 'r', encoding='utf-8') as r:
try:
print('found')
if click.confirm(f'Use local overrides from {local_overrides}?'):
kwargs = json.load(r)
print('loaded')
except Exception as e:
# Catch exception and dump a reason
click.echo('failed to load, dumping error message')
print(json.dumps(e, indent=4, sort_keys=True, default=str))
except FileNotFoundError:
logger.info('local overrides file not found')

_url = self.qs_url.format(dashboard_id=dashboard_id, **self.qs_url_params)

Expand Down
Loading