Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix typos #623

Merged
merged 2 commits into from
Sep 27, 2023
Merged

fix typos #623

merged 2 commits into from
Sep 27, 2023

Conversation

iakov-aws
Copy link
Collaborator

Issue #, if available:

Description of changes:

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@iakov-aws iakov-aws mentioned this pull request Sep 21, 2023
Closed
@iakov-aws iakov-aws merged commit e44d277 into main Sep 27, 2023
16 checks passed
@iakov-aws iakov-aws deleted the typos branch September 27, 2023 14:32
Npinmor96 added a commit to wompi-co/terraform-aws-comp-cudos that referenced this pull request Apr 23, 2024
@Npinmor96 @iakov-aws
@yprikhodko @gaborschulz-aws @rohitsinglagithub @dnmll @VoicuAWS @vmindru @chaitanyashah @esc1144 @sean-nixon @gucarreira @steffeng @ramyavij @qmg-drettie @sbalaji-aws @sumitagarwalHcst @juchavw @jannyg @remaws @MaximF @soumyavanga @udid-aws
Feature/cudos new v (#2)
9693d35 
* Update cost-anomalies.yaml (aws-samples#625)

* Tao 3 (aws-samples#626)

* dataset updates for TAO 3

* fix calc field order

---------

Co-authored-by: Prykhodko <yuriypr@a07817b4937d.ant.amazon.com>

* fix typos (aws-samples#623)

* fix logic (aws-samples#607)

* Minor fixes (aws-samples#610)

* Added automated Athena workgroup creation if missing (aws-samples#618)

* Feature: Allow custom Role for QuickSight DataSet (aws-samples#606)

* bump version (aws-samples#622)

* Tao 3 (aws-samples#627)

* dataset updates for TAO 3

* fix calc field order

* added changelog

---------

Co-authored-by: Prykhodko <yuriypr@a07817b4937d.ant.amazon.com>

* Update CHANGELOG-tao.md (aws-samples#629)

* bump release (aws-samples#630)

* Release2.28 (aws-samples#631)

* Update CHANGELOG-tao.md (aws-samples#632)

* Update CHANGELOG-tao.md (aws-samples#633)

* fix cfn for data collection lab (aws-samples#636)

* typo and lint (aws-samples#635)

* Allow SQL datasets for export (aws-samples#638)

* fix release script (aws-samples#628)

* Bugfix for workgroup creation in non us-east-1 region (aws-samples#642)

* Add Cloudfront Dashboards (aws-samples#639)

* Feature user add paginator (aws-samples#645)

* Bugfix to handle empty datasetarns (aws-samples#640)

* bump release (aws-samples#643)

* Fixing missing permissions for proper QS functioning after deploy (aws-samples#644)

* Data transfer dashboard initial migration from WAL to Workshopstudio (aws-samples#647)

* Fixed QS Data Source policy name collision (aws-samples#649)

* Adding missing perms, this prevents applying rls on customer_all ds (aws-samples#651)

Co-authored-by: vmindru <vmindru@amazon.com>

* Expanding load resources (aws-samples#653)

* bump release (aws-samples#654)

* allways allow access to data collection bucket for account map access (aws-samples#656)

* Feature - better status - shows owners and last dataset ingestion   (aws-samples#660)

* Fix cfn - add databases permissions for data collection lab (aws-samples#663)

* Feature catalog (aws-samples#658)

* release/0.2.31 (aws-samples#664)

* Update common.py (aws-samples#665)

* Update resources.yaml (aws-samples#666)

* allow data collection bucket not to exist (aws-samples#667)

* Fix permisions (aws-samples#668)

* allow data collection bucket not to exist

* fix permissions

* fix some titles in cur deploy (aws-samples#670)

* Cudos v5 (aws-samples#661)

* bump release (aws-samples#671)

* cfn changes for cudos v5 (aws-samples#662)

* cfn changes for cudos v5

* bump release (aws-samples#672)

* Update resources.yaml (aws-samples#673)

* bump release (aws-samples#674)

* Release 0.2.35 (aws-samples#676)

* Changelog Update for CUDOS v5 (aws-samples#675)

* chnage names of resources for better update and remove CidVersion (aws-samples#678)

* Terraform: S3 object tags and fix for continous drift with KMS-encrypted bucket (aws-samples#679)

Co-authored-by: Sean Nixon <smnixon@amazon.com>

* fix hourly_view (aws-samples#681)

* replace deepmerge by custom code (aws-samples#682)

* Update fixes (aws-samples#684)

* fix-empty-categories (aws-samples#677)

* Add product storage fields and better messages if CUR does not contain fields (aws-samples#680)

* bump release (aws-samples#685)

* change test to cudos v5 (aws-samples#686)

* Update CHANGELOG-cudos.md (aws-samples#687)

* Fixed supported dashboards links (aws-samples#690)

* update demo links (aws-samples#691)

* cleanup old files (aws-samples#688)

* release 0.2.37 (aws-samples#694)

* exclude known views and enforce naming (aws-samples#693)

* fix account map creation (aws-samples#689)

* release 0.2.38 (aws-samples#696)

* Fixes queries for sustainability proxy metrics dashboard (aws-samples#697)

* AWS Marketplace Single Pane of Glass (SPG) Dashboard v0.0.1 (aws-samples#692)

* release 0.2.39 (aws-samples#699)

* fixes joins for multiple business metrics per hour (aws-samples#700)

* update boto3 requirements (aws-samples#698)

* Update CHANGELOG-tao.md (aws-samples#701)

* Better error handling (aws-samples#702)

* fix: add glue:GetPartition action to QuickSightDataSourceRole (aws-samples#706)

* add checkov lints script (aws-samples#703)

* fix definitions deploy (aws-samples#707)

* allow choice of category (aws-samples#708)

* Manage CUR fields (aws-samples#710)

* fix non utf8 chars (aws-samples#713)

* release 0.2.40 (aws-samples#709)

* release 0.2.41 (aws-samples#715)

* Update links and bucket name to reflect data collection v3 (aws-samples#716)

* adjusting default s3 path to cid-data- prefix (aws-samples#717)

* release 0.2.42 (aws-samples#718)

* fix update from legacy (aws-samples#720)

* Update CHANGELOG-cudos.md (aws-samples#721)

* Update CHANGELOG-cudos.md

* Update CHANGELOG-cudos.md

* Fix QuickSight dataset refresh schedule creation for hourly_view and resource_view (aws-samples#726)

* release 0.2.43 (aws-samples#727)

* Changed the reference from user to group (aws-samples#728)

* release 0.2.44 (aws-samples#729)

* Update CHANGELOG-cudos.md (aws-samples#730)

* Update CHANGELOG-cudos.md (aws-samples#731)

* support paritions (aws-samples#723)

* more resilence to catalog errors (aws-samples#732)

* release 0.2.45 (aws-samples#733)

* Update CidSpiceRefreshLambda function (aws-samples#736)

* Update CidSpiceRefreshLambda function

Recently we implemented a fix (PR # 726) to resolve the dataset refresh scheduling issue for hourly_view and resource_view in CUDOS v5 dashboard.

In order to implement the fix for existing customers who have already deployed the CUDOS v5 dashboard, I have made changes to the CidSpiceRefreshLambda function by adding hourly_view and resource_view in it.

* Update version

Updated the version 0.2.45 to 0.2.46

* make url compatibile with China regions (aws-samples#738)

* create schedule even if we cannot see it (aws-samples#737)

* Fixes for KMS bucket encryption use case (aws-samples#741)

* Update CHANGELOG-cid.md (aws-samples#744)

* Update cid-cfn.yml (aws-samples#746)

* Update CHANGELOG-cudos.md (aws-samples#747)

* feat: adding RDS Extended Support Cost Projection dashboard definition and catalog entry.

* add context manager for parameters (aws-samples#748)

* add context manager for parameters

* add context manager for parameters

* Voicu aws/refresh datasets command (aws-samples#754)

* Refresh datasets in status command

---------

Co-authored-by: Voicu Chirtes <voicuaws@gmail.com>
Co-authored-by: Voicu <99695945+VoicuAWS@users.noreply.github.com>

* Removing actual cost fields, EDP parameter and adding 'About' sheet with legal notice, dashboard author information and links to the CID portal and email.

* removing default choice (aws-samples#757)

* Support theme (aws-samples#758)

* Yprikhodko patch 5 (aws-samples#760)

* Update CHANGELOG-cudos.md

* Update CHANGELOG-cudos.md

* Update CHANGELOG-cudos.md

* Update CHANGELOG-cudos.md

* Update CHANGELOG-cid.md (aws-samples#755)

* allow CN region and add lint (aws-samples#759)

* allow CN region and add lint

* add cfn-nag

* Update .github/workflows/security-scan.yml

* support cur replication for cn (aws-samples#753)

* support cur replication for cn

* Update cur-aggregation.yaml

* release 0.2.47 (aws-samples#742)

* fix managed policy (aws-samples#762)

* fix managed policy

* update python for checkov

* add checkov dep

* add checkov dep

* remove support of python3.7 and 3.8, add 3.12 and Bump boto3  (aws-samples#761)

* rename rds extended support to extended support (aws-samples#765)

* rename rds extended support to extended support

* more re-naming

* Update extended-support-cost-projection.yaml (aws-samples#766)

* Update extended-support-cost-projection.yaml

* Update extended-support-cost-projection.yaml

* Create Crawlers and IAM Roles for Datasource

* wip

* add management of CUR fields

* wip

* better type management

* refactoring

* fixes

* add warning if crawler is not well configured

* sort

* fix import

* refactoring cur

* remove resource id dep

* remove resource_id dep

* more refactoring

* more refactoring

* fixes

* fixes

* add cur creation

* fixes

* fixes

* fixes

* better creation workflow and messages plus database creation

* doc and workflow fixes

* doc and workflow fixes

* add cur.yaml

* add QS DS role management

* refactor iam

* allow customer to create dataset with new QS role

* release 0.3.0

* refactor export

* lint

* lint

* fix cur yaml

* fix role creation

* workaround IAM

* wip

* more fixes

* various fixes for the crawler and roles

* various fixes for the crawler and roles

* Update cid/helpers/quicksight/__init__.py

Co-authored-by: Yuriy Prykhodko <yprikhodko@gmail.com>

* Update cid/cli.py

Co-authored-by: Yuriy Prykhodko <yprikhodko@gmail.com>

* Update cid/commands/init_qs.py

Co-authored-by: Yuriy Prykhodko <yprikhodko@gmail.com>

* Update cid/commands/init_qs.py

Co-authored-by: Yuriy Prykhodko <yprikhodko@gmail.com>

* review fixes

* wip

* align roles

* lint

* more fixes

* minor fixes

* align role names

* fix comment

* remove print

* Update cid/common.py

Co-authored-by: Yuriy Prykhodko <yprikhodko@gmail.com>

* Update cid/common.py

Co-authored-by: Yuriy Prykhodko <yprikhodko@gmail.com>

---------

Co-authored-by: Yuriy Prykhodko <yprikhodko@gmail.com>

* Support for Permissionboundary and custom role paths (aws-samples#745)

* graviton-opportunities-dashboard yaml (aws-samples#769)

* graviton dashboard folder

* Add files via upload

* Delete dashboards/graviton-opportunties-dashboard/readme.md

* Add files via upload

updated yaml file to v0.0.4

* Delete dashboards/graviton-opportunties-dashboard/graviton_dashboard_0.0.3.yaml

* Update catalog.yaml

* Rename graviton_dashboard_0.0.4.yaml to graviton_dashboard.yaml

* fix typo in folder name (aws-samples#770)

* Update dashboard id in graviton_dashboard.yaml (aws-samples#771)

* docs: fix README typos (aws-samples#774)

* Add status video (aws-samples#775)

* Update README.md

* Update README.md

* Update graviton_dashboard.yaml (aws-samples#776)

* Update graviton_dashboard.yaml (aws-samples#777)

* fix-policies-duplication (aws-samples#773)

* fix co path (aws-samples#778)

* Create CHANGELOG-aws-marketplace-spg.md (aws-samples#781)

Added changelog for v0.1.1 for AWS Marketplace single pane of glass

* Update last_kpi_tracker_view.sql (aws-samples#779)

* Update last_kpi_tracker_view.sql -  fix duplicate linked account data in the scenario where a linked account is moved from one org to other.

* Fix s3 object hash

* new dashboard scad-cca (aws-samples#786)

* Changed category to "Additional" (aws-samples#788)

* Adding EKS Extended Support Cost Projection dashboard definition (aws-samples#785)

* Adding EKS Extended Support Cost Projection dashboard definition, supporting dataset and view.

* Adding filtering by cluster version action in the main details table. Changing dashboard category back to 'Advanced'.

* Adjusting name for discount parameter and associated calculated fields.

* Added change log for the EKS Extended Support Cost Projection dashboard. (aws-samples#789)

* Better process from 0 (aws-samples#782)

* better choosing of name

* enhancements for flowless cretion of dashboard

* better export

* Fix permissions boundaries + release 0.3.1 (aws-samples#790)

* add-databases-permission (aws-samples#791)

* release 0.3.2 (aws-samples#793)

* fix-ri-sp-without-crawler (aws-samples#792)

---------

Co-authored-by: Iakov GAN <82834333+iakov-aws@users.noreply.github.com>
Co-authored-by: Yuriy Prykhodko <yprikhodko@gmail.com>
Co-authored-by: Prykhodko <yuriypr@a07817b4937d.ant.amazon.com>
Co-authored-by: Gabor Schulz <119935302+gaborschulz-aws@users.noreply.github.com>
Co-authored-by: rohitsinglagithub <rohit.singla@yahoo.com>
Co-authored-by: Dan Malloy <91972154+dnmll@users.noreply.github.com>
Co-authored-by: Voicu <99695945+VoicuAWS@users.noreply.github.com>
Co-authored-by: Veaceslav Mindru <mindruv@gmail.com>
Co-authored-by: Chaitanya Shah <chaitanyashah@users.noreply.github.com>
Co-authored-by: Eric Christensen <64806114+esc1144@users.noreply.github.com>
Co-authored-by: vmindru <vmindru@amazon.com>
Co-authored-by: Sean Nixon <sean-nixon@users.noreply.github.com>
Co-authored-by: Sean Nixon <smnixon@amazon.com>
Co-authored-by: Gustavo Carreira <gucarreira@gmail.com>
Co-authored-by: Steffen Grunwald <steffeng@amazon.de>
Co-authored-by: ramyavij <150645025+ramyavij@users.noreply.github.com>
Co-authored-by: David Rettie <60602475+qmg-drettie@users.noreply.github.com>
Co-authored-by: sbalaji-aws <158212454+sbalaji-aws@users.noreply.github.com>
Co-authored-by: sumitagarwalHcst <31927130+sumitagarwalHcst@users.noreply.github.com>
Co-authored-by: Julio Chaves <jchavesf@amazon.com>
Co-authored-by: Voicu Chirtes <voicuaws@gmail.com>
Co-authored-by: juchavw <145122756+juchavw@users.noreply.github.com>
Co-authored-by: Jan-Arve Nygård <jan.arve.nygard@gmail.com>
Co-authored-by: Rem Baumann <110177550+remaws@users.noreply.github.com>
Co-authored-by: Maxim Fedchishin <sevmax@gmail.com>
Co-authored-by: Soumya Vanga <soumya437@gmail.com>
Co-authored-by: Udi Dahan <141835735+udid-aws@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yprikhodko yprikhodko yprikhodko approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@iakov-aws @yprikhodko