Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CUR proxy + CUR 2.0 - Major v4.0.0 #807

Merged
merged 105 commits into from
Nov 6, 2024
Merged

CUR proxy + CUR 2.0 - Major v4.0.0 #807

merged 105 commits into from
Nov 6, 2024

Conversation

iakov-aws
Copy link
Collaborator

Issue #, if available:

Description of changes:

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Copy link
Contributor

@petrokashlikov petrokashlikov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Submitted few comments. Also wasn't able to understand full logic as of now.

Copy link
Contributor

@petrokashlikov petrokashlikov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added more questions/comments

cid/helpers/cur_proxy.py Fixed Show fixed Hide fixed
cid/helpers/account_map.py Fixed Show fixed Hide fixed
cfn-templates/cid-plugin.yml Dismissed Show dismissed Hide dismissed
Copy link
Contributor

@petrokashlikov petrokashlikov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@iakov-aws iakov-aws merged commit fedb14d into main Nov 6, 2024
15 checks passed
@iakov-aws iakov-aws deleted the cur-proxy branch November 6, 2024 08:47
@iakov-aws iakov-aws restored the cur-proxy branch November 6, 2024 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants