Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cur proxy and dataprovider managment #945

Merged
merged 4 commits into from
Sep 24, 2024

Conversation

iakov-aws
Copy link
Collaborator

Issue #, if available:

Description of changes:

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

cfn-templates/cid-admin-policies.yaml Dismissed Show dismissed Hide dismissed
- iam:CreatePolicyVersion
- iam:DeletePolicyVersion
Effect: Allow
Resource:

Check notice

Code scanning / CodeGuru Reviewer Scanner

resources hard coded arn properties Low

ARN in Resource CloudIntelligenceDashboardsCFNManagementPolicy contains hardcoded Partition in ARN or incorrectly placed Pseudo Parameters
''' return a list of read access policies provided by other stacks
key: cfn export name
'''
return self.get_read_access_policies().get(key)

Check notice

Code scanning / CodeGuru Reviewer Scanner

Risky use of dict get method Low

You are using the get method without a default argument to return the value of a key in a dictionary. We recommended that you use a default argument so that if the value for your key is not found, a default value is returned. If a default value is not provided and the key is not found, then None is returned.

Learn more

Suggested remediation:
Using the get method without a default argument to return the value of a key in a dictionary can cause undesirable results.
<br>@@ -49,5 +49,5 @@<br> key: cfn export name<br> '''<br>- return self.get\_read\_access\_policies().get(key)<br>+ return self.get\_read\_access\_policies().get(key, 'Enter default value')<br> <br> <br><br>
@iakov-aws iakov-aws merged commit da415d5 into cur-proxy Sep 24, 2024
9 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant