ブラウザ拡張機能: SAML認証対応 #616
Merged
ブラウザ拡張機能: SAML認証対応 #616
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wadabee
commented
Aug 23, 2024
Comment on lines
+7
to
+20
| const { settings } = useSettings(); | ||
|
|
||
| const { data: session, mutate } = useSWR(settings ? 'auth' : null, () => { | ||
| return fetchAuthSession(); | ||
| }); | ||
|
|
||
| const loading = useMemo(() => { | ||
| return !settings || !session; | ||
| }, [session, settings]); | ||
|
|
||
| return { | ||
| hasAuthrized: !!session?.tokens, | ||
| authenticate: mutate, | ||
| loading, | ||
| hasAuthenticated: !!session?.tokens, |
There was a problem hiding this comment.
Amplify UIで認証に関する処理を行うuseAuthenticatorというHooksがありますが、以下の理由で利用していません。
- 今回認証に関する設定（useSettings）を非同期に取得しているが、設定の取得完了を待たずに、useAuthenticatorが認証ステータスを取得しにいくため、正確なステータスが取得できない
- 設定の取得完了のタイミングで、認証ステータスを更新したいが、useAuthenticatorに任意のタイミングで認証ステータスを取得する関数がない
- 今回、SWRのmutateを利用して、任意のタイミングで認証セッションを取得し、その中身で認証状態を判断するようなロジックとしている
wadabee
commented
Aug 23, 2024
Comment on lines
+1
to
+15
| <!doctype html> | ||
| <html lang="ja"> | ||
|
|
||
| <head> | ||
| <meta charset="UTF-8" /> | ||
| <meta name="viewport" content="width=device-width, initial-scale=1.0" /> | ||
| <meta http-equiv="X-UA-Compatible" content="ie=edge" /> | ||
| </head> | ||
|
|
||
| <body style="background-color: #232f3e"> | ||
| <div id="root"></div> | ||
| <script src="./index.tsx" type="module"></script> | ||
| </body> | ||
|
|
||
| </html> |
There was a problem hiding this comment.
SAML認証を行う際は、CognitoのHosted UIからコールバックさせる必要があるので、新しいタブで認証画面を開くようにしています。
iframeに埋め込まれた状態だと、親画面のURLにコールバックすることになり、Cognito 側でブロックされます。
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
ブラウザ拡張機能をSAML認証に対応しました。
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.