Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

削除の追加 #69

Merged
merged 2 commits into from
Sep 19, 2023
Merged

削除の追加 #69

merged 2 commits into from
Sep 19, 2023

Conversation

wadabee
Copy link
Contributor

@wadabee wadabee commented Sep 19, 2023

Issue #, if available:
#39

Description of changes:

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Copy link
Contributor

@tbrand tbrand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Modal 開いた時に以下の warning が出るのですが、これは headlessui のせいですかね?確認をお願いできれば:pray:
validateDOMNesting(...): <div> cannot appear as a descendant of <p>.

_chatId: string
): Promise<void> => {
const chatItem = await findChatById(_userId, _chatId);
console.log(chatItem);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

消し忘れ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

消し忘れだったので、削除しました。

@wadabee
Copy link
Contributor Author

wadabee commented Sep 19, 2023

Modal 開いた時に以下の warning が出るのですが、これは headlessui のせいですかね?確認をお願いできれば🙏 validateDOMNesting(...): <div> cannot appear as a descendant of <p>.

headlessUIのドキュメント上のサンプルコードのエラーでした。
p タグを div タグに置き換えて、エラーを解消させました!

@tbrand tbrand merged commit fd4af51 into main Sep 19, 2023
1 check passed
@tbrand tbrand deleted the add-delete-chat branch September 19, 2023 04:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants