Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

モデルの機能のフラグ管理 #769

Merged
merged 6 commits into from
Dec 10, 2024
Merged

モデルの機能のフラグ管理 #769

merged 6 commits into from
Dec 10, 2024

Conversation

maekawataiki
Copy link
Collaborator

@maekawataiki maekawataiki commented Dec 6, 2024

変更内容の説明

#701

モデルの機能対応状況(ドキュメントチャット、画像チャット、動画チャット)をフラグで管理し、フロントエンドに反映し意図せぬエラーを防ぐ。
https://docs.aws.amazon.com/bedrock/latest/userguide/conversation-inference-supported-models-features.html

チェック項目

  • npm run lint を実行した
  • 関連するドキュメントを修正した
  • 手元の環境で動作確認済み

関連する Issue

関連する Issue を可能な限り挙げてください。

@maekawataiki maekawataiki changed the title [WIP] モデルの機能のフラグ管理 モデルの機能のフラグ管理 Dec 6, 2024
Copy link
Contributor

@tbrand tbrand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

onChangeFiles の uploadFiles に props?.accept が必要ですかね?

packages/common/package.json Outdated Show resolved Hide resolved
packages/cdk/tsconfig.json Show resolved Hide resolved
Copy link
Contributor

@tbrand tbrand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!

@tbrand tbrand merged commit 146c8a1 into main Dec 10, 2024
2 checks passed
@tbrand tbrand deleted the feat/model-feature-flag branch December 10, 2024 01:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants