Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

文章校正ユーズケースの追加 #92

Merged
merged 11 commits into from
Oct 13, 2023

Conversation

maekawataiki
Copy link
Collaborator

Issue #, if available:
#91

Description of changes:

  • 文章校正ユーズケースの追加
  • lint の結果関係ないファイルに変更が少し入ってしまってます

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Copy link
Contributor

@tbrand tbrand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

キャメルケースなどいくつか微修正をコメントしました!大枠としては問題ないと思います!素晴らしいユースケースですね 👍
あと、最初は文章を変更すると自動で読み込みが開始されると思うのですが、2回目以降は手動というのは想定されている動作でしょうか?

packages/web/src/hooks/useChat.ts Outdated Show resolved Hide resolved
packages/web/src/hooks/useChat.ts Outdated Show resolved Hide resolved
packages/web/src/hooks/useChat.ts Outdated Show resolved Hide resolved
@maekawataiki
Copy link
Collaborator Author

現状仕様としてはリクエスト数を減らすために、

  • コメントを直接削除/ハイライト部分を変更するとコメント削除
  • 全てのコメントがなくなると再度校正が行われる

というロジックにしているため、他のコメントが残っている状態だと自動で新たな校正が走らないようになっています。
欠点としては追記した際校正が走らないので手動で校正を走らせる必要がある点です。

packages/web/src/prompts/index.ts Outdated Show resolved Hide resolved
packages/web/src/hooks/useChat.ts Show resolved Hide resolved
packages/web/src/pages/EditorialPage.tsx Outdated Show resolved Hide resolved
packages/web/src/components/TextEditor.tsx Outdated Show resolved Hide resolved
packages/web/src/components/TextEditor.tsx Outdated Show resolved Hide resolved
packages/web/src/components/TextEditor.tsx Outdated Show resolved Hide resolved
packages/web/src/components/TextEditor.tsx Outdated Show resolved Hide resolved
packages/web/src/pages/EditorialPage.tsx Show resolved Hide resolved
packages/web/src/prompts/index.ts Outdated Show resolved Hide resolved
packages/web/src/pages/EditorialPage.tsx Outdated Show resolved Hide resolved
@wadabee wadabee merged commit 665d5cc into aws-samples:main Oct 13, 2023
1 check passed
@wadabee
Copy link
Contributor

wadabee commented Oct 13, 2023

LGTM!!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants