-
Notifications
You must be signed in to change notification settings - Fork 930
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New serverless pattern - firehose-transformation-terraform #1589
New serverless pattern - firehose-transformation-terraform #1589
Conversation
May I know the next steps from here? Please advise. |
Yes, it takes up to 14 business days for a review, during which we test the pattern. Any additional feedback will take another 7-14 days to review. |
@@ -0,0 +1,116 @@ | |||
# Kinesis Firehose Data Transformation with Lambda (Terraform) | |||
# Transform incoming source data and deliver the transformed data to destinations. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please fix the title, only one header 1 and then description
2. Change the working directory to this pattern's directory | ||
|
||
```sh | ||
cd serverless-patterns/kinesis-firehose-data-transformation-lambda-terraform |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the name doesnt match with the directory name
two small fixes that this pr needs and then is ready for merge. |
@mavi888 - Thanks for sharing the comments. I have resolved/applied the changes in the branch. Kindly proceed with the next steps and let me know if any further changes are required. |
Thanks for submitting this pattern. Cheers |
Issue #, if available:
Description of changes:
Kinesis Firehose Data Transformation with Lambda through Terraform. Transform incoming source data and deliver the transformed data to destinations.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.