Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New serverless pattern : Lambda event generation, their distribution via EventBridge rules to rate controlled processing using SQS+Lambda #2020

Merged

Conversation

anaghlal
Copy link
Contributor

@anaghlal anaghlal commented Jan 8, 2024

Issue #, if available:

Description of changes:
Lambda event generation, their distribution via EventBridge rules to rate controlled processing using SQS+Lambda

The pattern demonstrates creating and sending events to EventBridge, routing them to targets based on message contents to SQS targets consumed by Lambdas.
"language": "Python"
"framework": "CDK"

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Copy link

github-actions bot commented Jan 9, 2024

@undefined your 'example-pattern.json' is missing some key fields, please review below and address any errors you have

  1. title: title does not meet maximum length of 75
  2. description: description does not meet maximum length of 150

If you need any help, take a look at the example-pattern file.

Make the changes, and push your changes back to this pull request. When all automated checks are successful, the Serverless DA team will process your pull request.

@anaghlal
Copy link
Contributor Author

I have submitted a change with the title and description meeting the max length limits. How do I retrigger the bot?

Copy link

Valid pattern file found.

Reviewer you can view the pattern file here

Copy link
Contributor

@ellisms ellisms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor edits/comments to review before merging.

lambda-eventbridge-sqs-lambda-cdk-python/README.md Outdated Show resolved Hide resolved
lambda-eventbridge-sqs-lambda-cdk-python/README.md Outdated Show resolved Hide resolved
lambda-eventbridge-sqs-lambda-cdk-python/README.md Outdated Show resolved Hide resolved
lambda-eventbridge-sqs-lambda-cdk-python/README.md Outdated Show resolved Hide resolved
lambda-eventbridge-sqs-lambda-cdk-python/app.py Outdated Show resolved Hide resolved
lambda-eventbridge-sqs-lambda-cdk-python/app.py Outdated Show resolved Hide resolved
anaghlal and others added 8 commits January 11, 2024 00:16
Co-authored-by: ellisms <114107920+ellisms@users.noreply.github.com>
Co-authored-by: ellisms <114107920+ellisms@users.noreply.github.com>
Co-authored-by: ellisms <114107920+ellisms@users.noreply.github.com>
json file for publishing.
@ellisms
Copy link
Contributor

ellisms commented Jan 11, 2024

Changes look good, thanks!

One last question - since the pattern is focussed on rate limiting, can you feature the Lambda event source max concurrency feature in the example? I think that would tie the usage of SQS as the buffer to rate limiting.

@ellisms ellisms merged commit c83bd7f into aws-samples:main Jan 11, 2024
@benjasl-stripe
Copy link
Contributor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants