refactor: updating region_request.py and tests for the class #109
+143
−62
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available: n/a
Notes
This PR introduces improvements to the
RegionRequest
class, focusing on cleaner initialization, enhanced validation, and updated unit tests to ensure robust functionality and maintainability. The PR also deletes the test_api.py file as all the tests that were there have been migrated to the associatedImageRequest
andRegionRequest
class tests.Key Changes:
Improved Initialization:
Enhanced Validation Logic:
is_valid()
method to ensureregion_bounds
is properly set and not left as the default, improving robustness.Comprehensive Attribute Documentation:
Updated and Expanded Unit Tests:
image_id
andregion_bounds
.unittest
structure, making it easier to run, debug, and maintain.Checklist
Before you submit a pull request, please make sure you have the following:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.