Remove unused TURN credentials path #2749
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ltrung
previously approved these changes
Sep 8, 2023
hensmi-amazon
force-pushed
the
remove-turn-creds
branch
from
97374c6 to
08aed90
Compare
ltrung
previously approved these changes
Nov 29, 2023
hensmi-amazon
force-pushed
the
remove-turn-creds
branch
from
08aed90 to
7cb8061
Compare
hensmi-amazon
force-pushed
the
remove-turn-creds
branch
from
4bf88ee to
ac71f7e
Compare
ltrung
approved these changes
Feb 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #: None
Description of changes: This path will never be hit because JoinAcks have included credentials for the past 3 years :).
Testing:
Joined a meeting, exchanged video.
Can these tested using a demo application? Please provide reproducible step-by-step instructions.
N/a just removing dead code.
Checklist:
Have you successfully run
npm run build:releaselocally?y
Do you add, modify, or delete public API definitions? If yes, has that been reviewed and approved?
y
Do you change the wire protocol, e.g. the request method? If yes, has that been reviewed and approved?
y
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.