Send a few additional metrics to backend #2750
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shi-su
force-pushed
the
feature-metric
branch
from
3bad4eb to
94d531e
Compare
hensmi-amazon
previously approved these changes
Sep 18, 2023
shi-su
force-pushed
the
feature-metric
branch
from
94d531e to
a135c99
Compare
shi-su
force-pushed
the
feature-metric
branch
from
a135c99 to
76aa441
Compare
hensmi-amazon
approved these changes
Sep 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #:
Description of changes:
Send a few additional metrics to backend (i.e., video freeze duration/count, video pause duration/count, frame drop, encoding quality limitation duration per second due to CPU).
Testing:
Smoke tested to verify the additional metrics are emitted and send to backend.
Can these tested using a demo application? Please provide reproducible step-by-step instructions.
n/a, just feature reporting changes. Can be verified at backend.
Checklist:
Have you successfully run
npm run build:releaselocally?y
Do you add, modify, or delete public API definitions? If yes, has that been reviewed and approved?
n
Do you change the wire protocol, e.g. the request method? If yes, has that been reviewed and approved?
n
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.