Prevent dataMessage callback errors from killing a meeting #2976
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ltrung
reviewed
Nov 4, 2024
| } | ||
| } | ||
| if (suppressedError) { | ||
| throw suppressedError; |
There was a problem hiding this comment.
So essentially, before we threw fatal error at the first error encountered but now we throw a non fatal error with the last one encountered?
ltrung
approved these changes
Nov 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move from #2975 to make integration tests work. Not trying to steal git coauthorship i swear!
Issue #: #2974
Description of changes:
Do not create a fatal error when the user-defined callbacks throw an error.
Testing:
Unit tested. POC tested in internal application.
Checklist:
Have you successfully run
npm run build:releaselocally?Yes
Do you add, modify, or delete public API definitions? If yes, has that been reviewed and approved?
No
Do you change the wire protocol, e.g. the request method? If yes, has that been reviewed and approved?
No
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Yes