Set starting send bitrate to 1000kbps to reduce time of low resolution at start of connection #2987
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n at start of connection
hensmi-amazon
commented
Nov 5, 2024
| @@ -927,8 +927,9 @@ export default class SDP { | |||
| // `x-google-start-bitrate` is an unofficial flag that has existed in libwebrtc since its release and is unlikely | |||
| // to be removed without notification. | |||
| // | |||
| // libwebrtc reference: https://webrtc.googlesource.com/src/+/b6ef1a736ee94d97cc28f3bd59b826c716a3278f/media/base/media_constants.cc#97 | |||
| const newLine = line + `;x-google-start-bitrate=${bitrateKbps * 1000}`; | |||
There was a problem hiding this comment.
Wow, wonder how this would have worked so far with * 1000 already added.
There was a problem hiding this comment.
It just uses the max bitrate configured, so nothing terrible.
shi-su
previously approved these changes
Nov 5, 2024
5 tasks
shi-su
approved these changes
Nov 5, 2024
devalevenkatesh
approved these changes
Nov 6, 2024
ltrung
reviewed
Nov 6, 2024
| @@ -5,32 +5,22 @@ All notable changes to this project will be documented in this file. | |||
| The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/), | |||
| and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html). | |||
|
|
|||
| ## [Unreleased] | |||
| ## [3.26.0] - 2024-10-07 | |||
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #: aws/amazon-chime-sdk-component-library-react#968
Description of changes: The original behavior isn't necessarily a bad thing, however I think the benefit of starting your video close to the intended quality on a clear network outweighs the risk aversion of a lower start bitrate. On a low-medium RTT connection I did not see any different in loss when enabling video before/after the change with my network constrained.
Testing:
Can these tested using a demo application? Please provide reproducible step-by-step instructions.
Checklist:
Have you successfully run
npm run build:releaselocally?y
Do you add, modify, or delete public API definitions? If yes, has that been reviewed and approved?
n
Do you change the wire protocol, e.g. the request method? If yes, has that been reviewed and approved?
n
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.