Add interface for custom CDN paths for VideoFxProcessor #3010
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
georgezy-amzn
previously approved these changes
Dec 2, 2024
ltrung
reviewed
Dec 2, 2024
| @@ -64,3 +66,11 @@ export const CDN_BASE_PATH: string = 'https://static.sdkassets.chime.aws'; | |||
| const MFX_ASSET_PATH = '/ml_media_fx/otherassets'; | |||
| export const WORKER_PATH: string = `${MFX_ASSET_PATH}/worker.js`; | |||
| export const FXLIB_PATH: string = `${MFX_ASSET_PATH}/fxlib.js`; | |||
|
|
|||
| export const DEFAULT_VIDEO_FX_SPEC: VideoFxSpec = { | |||
There was a problem hiding this comment.
There are some VideoFX files that are listed as internal here https://github.com/aws/amazon-chime-sdk-js/blob/main/script/barrelize.js#L65. Could we double check that we transpile all the needed files here in the build?
There was a problem hiding this comment.
good catch. Raising revision.
aman-aguptaaa
force-pushed
the
dev-aguptaaa
branch
from
a1f2e46 to
987a1ee
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #:
Description of changes:
Add interface to allow specifying custom CDN paths for VideoFxProcessor
Testing:
Added unit test.
Can these tested using a demo application? Please provide reproducible step-by-step instructions.
Checklist:
Have you successfully run
npm run build:releaselocally?Y
Do you add, modify, or delete public API definitions? If yes, has that been reviewed and approved?
N
Do you change the wire protocol, e.g. the request method? If yes, has that been reviewed and approved?
N
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.