fix(aws-cloudformation): Fix ParameterOverrides (#574)

ParameterOverrides needs to be a JSON-encoded object, not an object itself. Fixes #566.
aws · Aug 15, 2018 · 279df79 · 279df79
1 parent 939015a
commit 279df79
Show file tree

Hide file tree

Showing 2 changed files with 40 additions and 1 deletion.
diff --git a/packages/@aws-cdk/aws-cloudformation/lib/pipeline-actions.ts b/packages/@aws-cdk/aws-cloudformation/lib/pipeline-actions.ts
@@ -187,7 +187,7 @@ export abstract class CloudFormationDeploymentAction extends CloudFormationActio
             // This must be a string, so flatten the list to a comma-separated string.
             Capabilities: (capabilities && capabilities.join(',')) || undefined,
             RoleArn: new cdk.Token(() => this.role.roleArn),
-            ParameterOverrides: props.parameterOverrides,
+            ParameterOverrides: cdk.CloudFormationJSON.stringify(props.parameterOverrides),
             TemplateConfiguration: props.templateConfiguration ? props.templateConfiguration.location : undefined,
             StackName: props.stackName,
         });

diff --git a/packages/@aws-cdk/aws-codepipeline/test/test.cloudformation-pipeline-actions.ts b/packages/@aws-cdk/aws-codepipeline/test/test.cloudformation-pipeline-actions.ts
@@ -311,6 +311,45 @@ export = {
 
     test.done();
   },
+
+  'parameterOverrides are serialized as a string'(test: Test) {
+    // GIVEN
+    const stack = new TestFixture();
+
+    // WHEN
+    new CreateUpdateStack(stack, 'CreateUpdate', {
+      stage: stack.deployStage,
+      stackName: 'MyStack',
+      templatePath: stack.source.artifact.subartifact('template.yaml'),
+      parameterOverrides: {
+        RepoName: stack.repo.repositoryName
+      }
+    });
+
+    // THEN
+    expect(stack).to(haveResource('AWS::CodePipeline::Pipeline', {
+      "Stages": [
+        { "Name": "Source" /* don't care about the rest */ },
+        {
+          "Name": "Deploy",
+          "Actions": [
+            {
+              "Configuration": {
+                "ParameterOverrides": { "Fn::Join": [ "", [
+                  "{\"RepoName\":\"",
+                  { "Fn::GetAtt": [ "MyVeryImportantRepo11BC3EBD", "Name" ] },
+                  "\"}"
+                ]]}
+              },
+              "Name": "CreateUpdate",
+            },
+          ],
+        }
+      ]
+    }));
+
+    test.done();
+  }
 };
 
 /**