addressing last feedback comments

aws · Jun 14, 2024 · 57c00a2 · 57c00a2
1 parent 62b029b
commit 57c00a2
Show file tree

Hide file tree

Showing 5 changed files with 11 additions and 7 deletions.
diff --git a/packages/@aws-cdk/aws-vpcv2-alpha/lib/subnet-v2.ts b/packages/@aws-cdk/aws-vpcv2-alpha/lib/subnet-v2.ts
@@ -126,9 +126,8 @@ export class SubnetV2 extends Resource implements ISubnet {
   constructor(scope: Construct, id: string, props: SubnetPropsV2) {
     super(scope, id);
 
-    let ipv4CidrBlock: string | undefined;
-    let ipv6CidrBlock: string| undefined;
-
+    let ipv4CidrBlock: string = '';
+    let ipv6CidrBlock: string = '';
     if (props.cidrBlock instanceof Ipv4Cidr) {
       ipv4CidrBlock = props.cidrBlock.cidr;
     } else if (props.cidrBlock instanceof Ipv6Cidr) {

diff --git a/...-cdk/aws-vpcv2-alpha/test/integ.subnet-v2.js.snapshot/aws-cdk-vpcv2-alpha-new.assets.json b/...-cdk/aws-vpcv2-alpha/test/integ.subnet-v2.js.snapshot/aws-cdk-vpcv2-alpha-new.assets.json
diff --git a/...dk/aws-vpcv2-alpha/test/integ.subnet-v2.js.snapshot/aws-cdk-vpcv2-alpha-new.template.json b/...dk/aws-vpcv2-alpha/test/integ.subnet-v2.js.snapshot/aws-cdk-vpcv2-alpha-new.template.json
@@ -100,6 +100,7 @@
    "Properties": {
     "AvailabilityZone": "us-west-2a",
     "CidrBlock": "10.0.0.0/24",
+    "Ipv6CidrBlock": "",
     "VpcId": {
      "Fn::GetAtt": [
       "VPCTestFB735C86",

diff --git a/packages/@aws-cdk/aws-vpcv2-alpha/test/integ.subnet-v2.js.snapshot/manifest.json b/packages/@aws-cdk/aws-vpcv2-alpha/test/integ.subnet-v2.js.snapshot/manifest.json
diff --git a/packages/@aws-cdk/aws-vpcv2-alpha/test/integ.subnet-v2.js.snapshot/tree.json b/packages/@aws-cdk/aws-vpcv2-alpha/test/integ.subnet-v2.js.snapshot/tree.json