Skip to content

Commit

Permalink
fix(ecs-patterns): integ test unable to create ECS service (#29490)
Browse files Browse the repository at this point in the history
### Issue # (if applicable)

part of #29186 (comment)
same as #29333

### Reason for this change


CFN stack gets stuck after `yarn integ` because of not being able to create ECS service.

```
AWS::ECS::Service | CREATE_IN_PROGRESS
```

```
$ aws ecs describe-tasks --cluster aws-ecs-integ-lb-fargate-cmd-entrypoint-xxx --tasks xxxxxxxxxxxxxxx | jq '.tasks[].stopCode'
"EssentialContainerExited"
```

### Description of changes


Change `taskImageOptions` `image`, `command`, `entryPoint` and add security group.
Ref: https://docs.aws.amazon.com/AmazonECS/latest/developerguide/example_task_definitions.html#example_task_definition-webserver

### Description of how you validated changes


Pass integration tests

### Checklist
- [x] My code adheres to the [CONTRIBUTING GUIDE](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) and [DESIGN GUIDELINES](https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md)

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
  • Loading branch information
wafuwafu13 authored Mar 21, 2024
1 parent 07ce8ec commit 6faa60e
Show file tree
Hide file tree
Showing 8 changed files with 339 additions and 146 deletions.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading

0 comments on commit 6faa60e

Please sign in to comment.