improve tests

aws · Feb 9, 2024 · 8588356 · 8588356
1 parent 76d83a2
commit 8588356
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 5 deletions.
diff --git a/packages/@aws-cdk/aws-pipes-sources-alpha/lib/sqs.ts b/packages/@aws-cdk/aws-pipes-sources-alpha/lib/sqs.ts
@@ -31,23 +31,30 @@ export class SqsSource implements ISource {
   private readonly queue: IQueue;
   readonly sourceArn;
   private sourceParameters;
+
   constructor(queue: IQueue, parameters?: SqsSourceParameters) {
     this.queue = queue;
     this.sourceArn = queue.queueArn;
     if (parameters) {
       this.sourceParameters = parameters;
     }
   }
+
   bind(_pipe: IPipe): SourceConfig {
+    if (!this.sourceParameters) {
+      return {};
+    }
+
     return {
       sourceParameters: {
-        sqsQueueParameters: this.sourceParameters && {
+        sqsQueueParameters: {
           batchSize: this.sourceParameters?.batchSize,
           maximumBatchingWindowInSeconds: this.sourceParameters?.maximumBatchingWindow?.toSeconds(),
         },
       },
     };
   }
+
   grantRead(grantee: IRole): void {
     this.queue.grantConsumeMessages(grantee);
   }

diff --git a/packages/@aws-cdk/aws-pipes-sources-alpha/test/sqs.test.ts b/packages/@aws-cdk/aws-pipes-sources-alpha/test/sqs.test.ts
@@ -6,7 +6,7 @@ import { TestTarget } from './test-classes';
 import { SqsSource } from '../lib';
 
 describe('sqs', () => {
-  it('should have source arn', () => {
+  it('should have only source arn', () => {
     // ARRANGE
     const app = new App();
     const stack = new Stack(app, 'TestStack');
@@ -31,8 +31,8 @@ describe('sqs', () => {
           'Arn',
         ],
       },
+      SourceParameters: {},
     });
-
   });
 
   it('should have source parameters', () => {
@@ -64,7 +64,6 @@ describe('sqs', () => {
         },
       },
     });
-
   });
 
   it('should grant pipe role read access', () => {
@@ -87,6 +86,5 @@ describe('sqs', () => {
     // ASSERT
     expect(template.findResources('AWS::IAM::Role')).toMatchSnapshot();
     expect(template.findResources('AWS::IAM::Policy')).toMatchSnapshot();
-
   });
 });