Skip to content

Commit

Permalink
feat(apigatewayv2): add description property for stage (#30820)
Browse files Browse the repository at this point in the history
### Issue # (if applicable)

### Reason for this change

The `description` property existed in the L1 construct but was not present in the L2 construct

### Description of changes

Add the `description`  property for `HttpStage` and `WebSocketStage`, which was missing in the L2 construct.

### Description of how you validated changes

I Added both unit test and integration tests.

### Checklist
- [x] My code adheres to the [CONTRIBUTING GUIDE](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) and [DESIGN GUIDELINES](https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md)

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
  • Loading branch information
yoyoyo-pg authored Jul 22, 2024
1 parent 153a698 commit 8651bbe
Show file tree
Hide file tree
Showing 20 changed files with 158 additions and 70 deletions.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Original file line number Diff line number Diff line change
Expand Up @@ -13,11 +13,12 @@
"ApiId": {
"Ref": "HttpApiF5A9A8A7"
},
"StageName": "$default",
"DefaultRouteSettings": {
"ThrottlingBurstLimit": 1000,
"ThrottlingRateLimit": 1000
}
},
"Description": "My Stage",
"StageName": "$default"
}
}
},
Expand Down

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@ new apigw.HttpStage(stack, 'HttpStageWithProperties', {
rateLimit: 1000,
burstLimit: 1000,
},
description: 'My Stage',
});

app.synth();

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Original file line number Diff line number Diff line change
Expand Up @@ -14,11 +14,12 @@
"ApiId": {
"Ref": "WebSocketApi34BCF99B"
},
"StageName": "dev",
"DefaultRouteSettings": {
"ThrottlingBurstLimit": 1000,
"ThrottlingRateLimit": 1000
}
},
"Description": "My Stage",
"StageName": "dev"
}
}
},
Expand Down

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ new apigw.WebSocketStage(stack, 'WebSocketStage', {
rateLimit: 1000,
burstLimit: 1000,
},
description: 'My Stage',
});

app.synth();
Loading

0 comments on commit 8651bbe

Please sign in to comment.