chore: enforce @typescript-eslint/comma-dangle (#28991)

Enforcing `@typescript-eslint/comma-dangle` instead of the regular `eslint/comma-dangle`. This gives us additional linting on enums, generics, and tuples. Mostly, I care about the enums. https://github.com/typescript-eslint/typescript-eslint/blob/main/packages/eslint-plugin/docs/rules/comma-dangle.md https://medium.com/@nikgraf/why-you-should-enforce-dangling-commas-for-multiline-statements-d034c98e36f8 ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
aws · Feb 5, 2024 · 9604c62 · 9604c62
1 parent b261fea
commit 9604c62
Show file tree

Hide file tree

Showing 120 changed files with 157 additions and 157 deletions.
diff --git a/packages/@aws-cdk/aws-cloud9-alpha/lib/environment.ts b/packages/@aws-cdk/aws-cloud9-alpha/lib/environment.ts
@@ -38,7 +38,7 @@ export enum ConnectionType {
    * When using SSM, service role and instance profile aren't automatically created.
    * See https://docs.aws.amazon.com/cloud9/latest/user-guide/ec2-ssm.html#service-role-ssm
    */
-  CONNECT_SSM = 'CONNECT_SSM'
+  CONNECT_SSM = 'CONNECT_SSM',
 }
 
 /**

diff --git a/packages/@aws-cdk/aws-glue-alpha/lib/s3-table.ts b/packages/@aws-cdk/aws-glue-alpha/lib/s3-table.ts
@@ -36,7 +36,7 @@ export enum TableEncryption {
    *
    * @see https://docs.aws.amazon.com/AmazonS3/latest/dev/UsingClientSideEncryption.html
    */
-  CLIENT_SIDE_KMS = 'CSE-KMS'
+  CLIENT_SIDE_KMS = 'CSE-KMS',
 }
 
 export interface S3TableProps extends TableBaseProps {

diff --git a/packages/@aws-cdk/aws-iot-actions-alpha/lib/sns-topic-action.ts b/packages/@aws-cdk/aws-iot-actions-alpha/lib/sns-topic-action.ts
@@ -16,7 +16,7 @@ export enum SnsActionMessageFormat {
   /**
    * JSON message format.
    */
-  JSON = 'JSON'
+  JSON = 'JSON',
 }
 
 /**

diff --git a/packages/@aws-cdk/aws-lambda-python-alpha/lib/packaging.ts b/packages/@aws-cdk/aws-lambda-python-alpha/lib/packaging.ts
@@ -5,7 +5,7 @@ export enum DependenciesFile {
   PIP = 'requirements.txt',
   POETRY = 'poetry.lock',
   PIPENV = 'Pipfile.lock',
-  NONE = ''
+  NONE = '',
 }
 
 export interface PackagingProps {

diff --git a/packages/@aws-cdk/aws-pipes-alpha/lib/pipeVariable.ts b/packages/@aws-cdk/aws-pipes-alpha/lib/pipeVariable.ts
@@ -35,7 +35,7 @@ export enum PipeVariable {
   /**
    * The same as aws.pipes.event, but the variable only has a value if the original payload, either from the source or returned by the enrichment, is JSON. If the pipe has an encoded field, such as the Amazon SQS body field or the Kinesis data, those fields are decoded and turned into valid JSON. Because it isn't escaped, the variable can only be used as a value for a JSON field. For more information, see Implicit body data parsing.
    */
-  EVENT_JSON = '<aws.pipes.event.json>'
+  EVENT_JSON = '<aws.pipes.event.json>',
 
 }
 

diff --git a/packages/@aws-cdk/aws-redshift-alpha/lib/table.ts b/packages/@aws-cdk/aws-redshift-alpha/lib/table.ts
@@ -49,7 +49,7 @@ export enum TableAction {
   /**
    * Grants all available privileges at once to the specified user or user group.
    */
-  ALL
+  ALL,
 }
 
 /**

diff --git a/packages/@aws-cdk/cdk-cli-wrapper/lib/commands/common.ts b/packages/@aws-cdk/cdk-cli-wrapper/lib/commands/common.ts
@@ -15,7 +15,7 @@ export enum RequireApproval {
   /**
    * Only prompt for approval if there are security related changes
    */
-  BROADENING = 'broadening'
+  BROADENING = 'broadening',
 }
 
 /**

diff --git a/packages/@aws-cdk/cli-lib-alpha/lib/commands/common.ts b/packages/@aws-cdk/cli-lib-alpha/lib/commands/common.ts
@@ -15,7 +15,7 @@ export enum RequireApproval {
   /**
    * Only prompt for approval if there are security related changes
    */
-  BROADENING = 'broadening'
+  BROADENING = 'broadening',
 }
 
 /**

diff --git a/packages/aws-cdk-lib/aws-apigateway/lib/integration.ts b/packages/aws-cdk-lib/aws-apigateway/lib/integration.ts
@@ -260,7 +260,7 @@ export enum ContentHandling {
   /**
    * Converts a request payload from a binary blob to a base64-encoded string.
    */
-  CONVERT_TO_TEXT = 'CONVERT_TO_TEXT'
+  CONVERT_TO_TEXT = 'CONVERT_TO_TEXT',
 }
 
 export enum IntegrationType {
@@ -298,7 +298,7 @@ export enum IntegrationType {
    * For integrating the API method request with API Gateway as a "loop-back"
    * endpoint without invoking any backend.
    */
-  MOCK = 'MOCK'
+  MOCK = 'MOCK',
 }
 
 export enum PassthroughBehavior {
@@ -319,7 +319,7 @@ export enum PassthroughBehavior {
    * templates. However if there is at least one content type defined,
    * unmapped content types will be rejected with the same 415 response.
    */
-  WHEN_NO_TEMPLATES = 'WHEN_NO_TEMPLATES'
+  WHEN_NO_TEMPLATES = 'WHEN_NO_TEMPLATES',
 }
 
 export enum ConnectionType {
@@ -331,7 +331,7 @@ export enum ConnectionType {
   /**
    * For private connections between API Gateway and a network load balancer in a VPC
    */
-  VPC_LINK = 'VPC_LINK'
+  VPC_LINK = 'VPC_LINK',
 }
 
 export interface IntegrationResponse {

diff --git a/packages/aws-cdk-lib/aws-apigateway/lib/json-schema.ts b/packages/aws-cdk-lib/aws-apigateway/lib/json-schema.ts
@@ -4,7 +4,7 @@ export enum JsonSchemaVersion {
    * @see https://tools.ietf.org/html/draft-zyp-json-schema-04
    */
   DRAFT4 = 'http://json-schema.org/draft-04/schema#',
-  DRAFT7 = 'http://json-schema.org/draft-07/schema#'
+  DRAFT7 = 'http://json-schema.org/draft-07/schema#',
 }
 
 export enum JsonSchemaType {
@@ -14,7 +14,7 @@ export enum JsonSchemaType {
   ARRAY = 'array',
   NUMBER = 'number',
   INTEGER = 'integer',
-  STRING = 'string'
+  STRING = 'string',
 }
 
 /**

diff --git a/packages/aws-cdk-lib/aws-apigateway/lib/restapi.ts b/packages/aws-cdk-lib/aws-apigateway/lib/restapi.ts
@@ -956,7 +956,7 @@ export enum EndpointType {
   /**
    * For a private API and its custom domain name.
    */
-  PRIVATE = 'PRIVATE'
+  PRIVATE = 'PRIVATE',
 }
 
 class RootResource extends ResourceBase {

diff --git a/packages/aws-cdk-lib/aws-apigateway/lib/stage.ts b/packages/aws-cdk-lib/aws-apigateway/lib/stage.ts
@@ -131,7 +131,7 @@ export interface StageProps extends StageOptions {
 export enum MethodLoggingLevel {
   OFF = 'OFF',
   ERROR = 'ERROR',
-  INFO = 'INFO'
+  INFO = 'INFO',
 }
 
 export interface MethodDeploymentOptions {

diff --git a/packages/aws-cdk-lib/aws-apigateway/lib/usage-plan.ts b/packages/aws-cdk-lib/aws-apigateway/lib/usage-plan.ts
@@ -32,7 +32,7 @@ export interface ThrottleSettings {
 export enum Period {
   DAY = 'DAY',
   WEEK = 'WEEK',
-  MONTH = 'MONTH'
+  MONTH = 'MONTH',
 }
 
 /**
@@ -80,7 +80,7 @@ export interface ThrottlingPerMethod {
  * Type of Usage Plan Key. Currently the only supported type is 'ApiKey'
  */
 enum UsagePlanKeyType {
-  API_KEY = 'API_KEY'
+  API_KEY = 'API_KEY',
 }
 
 /**

diff --git a/packages/aws-cdk-lib/aws-apigatewayv2/lib/http/authorizer.ts b/packages/aws-cdk-lib/aws-apigatewayv2/lib/http/authorizer.ts
@@ -29,7 +29,7 @@ export enum AuthorizerPayloadVersion {
   VERSION_1_0 = '1.0',
 
   /** Version 2.0 */
-  VERSION_2_0 = '2.0'
+  VERSION_2_0 = '2.0',
 }
 
 /**

diff --git a/packages/aws-cdk-lib/aws-apigatewayv2/lib/http/route.ts b/packages/aws-cdk-lib/aws-apigatewayv2/lib/http/route.ts
@@ -164,7 +164,7 @@ enum HttpRouteAuthorizationType {
   CUSTOM = 'CUSTOM',
 
   /** No authorizer */
-  NONE = 'NONE'
+  NONE = 'NONE',
 }
 
 /**

diff --git a/packages/aws-cdk-lib/aws-apigatewayv2/lib/websocket/integration.ts b/packages/aws-cdk-lib/aws-apigatewayv2/lib/websocket/integration.ts
@@ -53,7 +53,7 @@ export enum PassthroughBehavior {
    * templates. However if there is at least one content type defined,
    * unmapped content types will be rejected with the same 415 response.
    */
-  WHEN_NO_TEMPLATES = 'WHEN_NO_TEMPLATES'
+  WHEN_NO_TEMPLATES = 'WHEN_NO_TEMPLATES',
 }
 
 /**

diff --git a/packages/aws-cdk-lib/aws-applicationautoscaling/lib/step-scaling-action.ts b/packages/aws-cdk-lib/aws-applicationautoscaling/lib/step-scaling-action.ts
@@ -154,7 +154,7 @@ export enum MetricAggregationType {
   /**
    * Maximum
    */
-  MAXIMUM = 'Maximum'
+  MAXIMUM = 'Maximum',
 }
 
 /**

diff --git a/packages/aws-cdk-lib/aws-appmesh/lib/service-discovery.ts b/packages/aws-cdk-lib/aws-appmesh/lib/service-discovery.ts
@@ -28,7 +28,7 @@ export enum IpPreference {
    * Use IPv6 when sending traffic to a local application.
    * First attempt to use IPv6 and fall back to IPv4 for service discovery.
    */
-  IPV6_PREFERRED = 'IPv6_PREFERRED'
+  IPV6_PREFERRED = 'IPv6_PREFERRED',
 }
 
 /**

diff --git a/packages/aws-cdk-lib/aws-appsync/lib/graphqlapi.ts b/packages/aws-cdk-lib/aws-appsync/lib/graphqlapi.ts
@@ -272,7 +272,7 @@ export enum Visibility {
   /**
    * Only accessible through a VPC
    */
-  PRIVATE = 'PRIVATE'
+  PRIVATE = 'PRIVATE',
 }
 
 /**

diff --git a/packages/aws-cdk-lib/aws-autoscaling/lib/auto-scaling-group.ts b/packages/aws-cdk-lib/aws-autoscaling/lib/auto-scaling-group.ts
@@ -2009,7 +2009,7 @@ export enum ScalingEvent {
   /**
    * Send a test notification to the topic
    */
-  TEST_NOTIFICATION = 'autoscaling:TEST_NOTIFICATION'
+  TEST_NOTIFICATION = 'autoscaling:TEST_NOTIFICATION',
 }
 
 /**
@@ -2134,7 +2134,7 @@ export enum ScalingProcess {
   AZ_REBALANCE = 'AZRebalance',
   ALARM_NOTIFICATION = 'AlarmNotification',
   SCHEDULED_ACTIONS = 'ScheduledActions',
-  ADD_TO_LOAD_BALANCER = 'AddToLoadBalancer'
+  ADD_TO_LOAD_BALANCER = 'AddToLoadBalancer',
 }
 
 // Recommended list of processes to suspend from here:

diff --git a/packages/aws-cdk-lib/aws-autoscaling/lib/step-scaling-action.ts b/packages/aws-cdk-lib/aws-autoscaling/lib/step-scaling-action.ts
@@ -142,7 +142,7 @@ export enum MetricAggregationType {
   /**
    * Maximum
    */
-  MAXIMUM = 'Maximum'
+  MAXIMUM = 'Maximum',
 }
 
 /**

diff --git a/packages/aws-cdk-lib/aws-backup/lib/resource.ts b/packages/aws-cdk-lib/aws-backup/lib/resource.ts
@@ -17,7 +17,7 @@ export enum TagOperation {
   /**
    * Dummy member
    */
-  DUMMY = 'dummy'
+  DUMMY = 'dummy',
 }
 
 /**

diff --git a/packages/aws-cdk-lib/aws-batch/lib/linux-parameters.ts b/packages/aws-cdk-lib/aws-batch/lib/linux-parameters.ts
@@ -247,7 +247,7 @@ export enum TmpfsMountOption {
   GID = 'gid',
   NR_INODES = 'nr_inodes',
   NR_BLOCKS = 'nr_blocks',
-  MPOL = 'mpol'
+  MPOL = 'mpol',
 }
 
 function renderTmpfs(tmpfs: Tmpfs): CfnJobDefinition.TmpfsProperty {

diff --git a/packages/aws-cdk-lib/aws-cloudformation/lib/cloud-formation-capabilities.ts b/packages/aws-cdk-lib/aws-cloudformation/lib/cloud-formation-capabilities.ts
@@ -37,5 +37,5 @@ export enum CloudFormationCapabilities {
    *
    * @link https://docs.aws.amazon.com/AWSCloudFormation/latest/APIReference/API_CreateStack.html
    */
-  AUTO_EXPAND = 'CAPABILITY_AUTO_EXPAND'
+  AUTO_EXPAND = 'CAPABILITY_AUTO_EXPAND',
 }
diff --git a/packages/aws-cdk-lib/aws-cloudfront/lib/distribution.ts b/packages/aws-cdk-lib/aws-cloudfront/lib/distribution.ts
@@ -750,7 +750,7 @@ export enum HttpVersion {
   /** HTTP 2 and HTTP 3 */
   HTTP2_AND_3 = 'http2and3',
   /** HTTP 3 */
-  HTTP3 = 'http3'
+  HTTP3 = 'http3',
 }
 
 /**
@@ -763,7 +763,7 @@ export enum PriceClass {
   /** PRICE_CLASS_100 + South Africa, Kenya, Middle East, Japan, Singapore, South Korea, Taiwan, Hong Kong, & Philippines */
   PRICE_CLASS_200 = 'PriceClass_200',
   /** All locations */
-  PRICE_CLASS_ALL = 'PriceClass_All'
+  PRICE_CLASS_ALL = 'PriceClass_All',
 }
 
 /**
@@ -775,7 +775,7 @@ export enum ViewerProtocolPolicy {
   /** Will redirect HTTP requests to HTTPS */
   REDIRECT_TO_HTTPS = 'redirect-to-https',
   /** Both HTTP and HTTPS supported */
-  ALLOW_ALL = 'allow-all'
+  ALLOW_ALL = 'allow-all',
 }
 
 /**
@@ -808,7 +808,7 @@ export enum OriginProtocolPolicy {
  */
 export enum SSLMethod {
   SNI = 'sni-only',
-  VIP = 'vip'
+  VIP = 'vip',
 }
 
 /**
@@ -822,7 +822,7 @@ export enum SecurityPolicyProtocol {
   TLS_V1_1_2016 = 'TLSv1.1_2016',
   TLS_V1_2_2018 = 'TLSv1.2_2018',
   TLS_V1_2_2019 = 'TLSv1.2_2019',
-  TLS_V1_2_2021 = 'TLSv1.2_2021'
+  TLS_V1_2_2021 = 'TLSv1.2_2021',
 }
 
 /**

diff --git a/packages/aws-cdk-lib/aws-cloudfront/lib/web-distribution.ts b/packages/aws-cdk-lib/aws-cloudfront/lib/web-distribution.ts
@@ -339,7 +339,7 @@ export interface S3OriginConfig {
 export enum CloudFrontAllowedMethods {
   GET_HEAD = 'GH',
   GET_HEAD_OPTIONS = 'GHO',
-  ALL = 'ALL'
+  ALL = 'ALL',
 }
 
 /**

diff --git a/packages/aws-cdk-lib/aws-cloudwatch-actions/lib/ec2.ts b/packages/aws-cdk-lib/aws-cloudwatch-actions/lib/ec2.ts
@@ -21,7 +21,7 @@ export enum Ec2InstanceAction {
   /**
    * Reboot the instance
    */
-  REBOOT = 'reboot'
+  REBOOT = 'reboot',
 }
 
 /**

diff --git a/packages/aws-cdk-lib/aws-cloudwatch-actions/lib/ssm.ts b/packages/aws-cdk-lib/aws-cloudwatch-actions/lib/ssm.ts
@@ -21,7 +21,7 @@ export enum OpsItemSeverity {
   /**
    * Set the severity to low
    */
-  LOW = '4'
+  LOW = '4',
 }
 
 /**
@@ -47,7 +47,7 @@ export enum OpsItemCategory {
   /**
    * Set the category to security
    */
-  SECURITY = 'Security'
+  SECURITY = 'Security',
 }
 
 /**

diff --git a/packages/aws-cdk-lib/aws-cloudwatch/lib/alarm.ts b/packages/aws-cdk-lib/aws-cloudwatch/lib/alarm.ts
@@ -96,7 +96,7 @@ export enum TreatMissingData {
   /**
    * The alarm does not consider missing data points when evaluating whether to change state
    */
-  MISSING = 'missing'
+  MISSING = 'missing',
 }
 
 /**

diff --git a/packages/aws-cdk-lib/aws-cloudwatch/lib/graph.ts b/packages/aws-cdk-lib/aws-cloudwatch/lib/graph.ts
@@ -810,7 +810,7 @@ export enum Shading {
   /**
    * Add shading below the annotation
    */
-  BELOW = 'below'
+  BELOW = 'below',
 }
 
 /**
@@ -830,7 +830,7 @@ export enum VerticalShading {
   /**
    * Add shading after the annotation
    */
-  AFTER = 'after'
+  AFTER = 'after',
 }
 
 /**
@@ -881,7 +881,7 @@ export enum LegendPosition {
   /**
    * Add shading below the annotation
    */
-  HIDDEN = 'hidden'
+  HIDDEN = 'hidden',
 }
 
 function mapAnnotation(yAxis: string): ((x: HorizontalAnnotation) => any) {

diff --git a/packages/aws-cdk-lib/aws-cloudwatch/lib/text.ts b/packages/aws-cdk-lib/aws-cloudwatch/lib/text.ts
@@ -11,7 +11,7 @@ export enum TextWidgetBackground {
   /**
   * Transparent background
   */
-  TRANSPARENT = 'transparent'
+  TRANSPARENT = 'transparent',
 }
 
 /**
-Original file line number
+Diff line change
@@ Expand Up / @@ -16,7 +16,7 @@ export enum SnsActionMessageFormat { @@
       /**
        * JSON message format.
        */
-      JSON = 'JSON'
+      JSON = 'JSON',
     }
     /**
@@ Expand Down @@