-
Notifications
You must be signed in to change notification settings - Fork 3.9k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
chore(assertions): misformatted doc string causes generated docs to c…
…utoff information #27392 (#31199) ### Issue #27392 Closes #27392 ### Reason for this change Following Comment format, https://github.com/aws/aws-cdk/blob/aca90272ca65fce47d8de50dc1b2c3ab04132a19/packages/aws-cdk-lib/assertions/lib/template.ts#L183 creates this following format in **.jsii** assembly ``` "docs": { "remarks": "Provide '*' to match all parameters in the template.", "summary": "the name of the parameter." }, ``` **Remarks** section is created by **jsii**, when **`@remarks`** is mentioned or it takes anything after first paragraph. (after first **`dot`**) Reference: https://github.com/aws/jsii/blob/50e6c47fb873fab894e3779bafb0e84c31287839/packages/%40jsii/spec/src/assembly.ts#L313-L321 ### Decision on approach 1. fix it from **jsii / from our documentation portal side**, by modifying configuration to show remarks also in portal. 2. convert this detail as summary by keeping it in first paragraph. [This PR implements this] ### Description of changes Changed ``` @param logicalId the name of the parameter. Provide `'*'` to match all parameters in the template. ``` To, NOTE, **. P** --> **, p** ``` @param logicalId the name of the parameter, provide `'*'` to match all parameters in the template. ``` ### Description of how you validated changes 1. `$ npx lerna run build --scope=aws-cdk-lib --skip-nx-cache` 1. Ran build inside **aws-cdk-lib** --> `username@aws-cdk-lib$ yarn build`, this created .jsii file with compressed form. 1. Now ran **yarn jsii** --> this uncompresses **.jsii** file and creates exact doc content inside **.jsii** file. 1. Checked, everything is placed inside **summary** ### Checklist - [x] My code adheres to the [CONTRIBUTING GUIDE](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) and [DESIGN GUIDELINES](https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md) ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
- Loading branch information
Showing
2 changed files
with
17 additions
and
17 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters