Skip to content

Commit

Permalink
fix(ec2): allow NAT instance to associate public IP (#31812)
Browse files Browse the repository at this point in the history
### Issue # (if applicable)

Closes #31711

### Reason for this change

When we set mapPublicIpOnLaunch=false for public subnets, NAT instances does not get public IP addresses assigned, resulting in non-working NAT instances.

Disabling mapPublicIpOnLaunch is recommended as AWS Config rule (and cdk-nag as well.)
https://docs.aws.amazon.com/config/latest/developerguide/subnet-auto-assign-public-ip-disabled.html

### Description of changes

Support `associatePublicIpAddress`

### Description of how you validated changes

New unit and integ tests.

### Checklist
- [ ] My code adheres to the [CONTRIBUTING GUIDE](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) and [DESIGN GUIDELINES](https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md)

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
  • Loading branch information
GavinZZ authored Oct 22, 2024
1 parent b22899f commit e96b4ce
Show file tree
Hide file tree
Showing 12 changed files with 1,987 additions and 1 deletion.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading

0 comments on commit e96b4ce

Please sign in to comment.