Skip to content

Commit

Permalink
fix(s3-notifications): multiple notifications doesn't work
Browse files Browse the repository at this point in the history
When multiple bucket notifications are created it creates a race
condition where only the last one processed gets applied. All bucket
notifications created in a stack are given the same `stackId` prefix.
This prefix is then used to filter out the notification created by the
custom resource. If there are other notifications created in the same
stack, but not by this custom resource, they get filtered out.

This PR fixes that by filtering the notifications by the specific
notification id. This ensures that only the notifications created by the
individual custom resource are filter out and the rest (included those
created by other custom resources) are marked external.
  • Loading branch information
corymhall committed Nov 25, 2023
1 parent c66e197 commit eddbd3b
Show file tree
Hide file tree
Showing 12 changed files with 35,997 additions and 2 deletions.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading

0 comments on commit eddbd3b

Please sign in to comment.