-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(init-templates): allow renaming in templates for cdk migrate apps #27166
Merged
Merged
Changes from all commits
Commits
Show all changes
49 commits
Select commit
Hold shift + click to select a range
bacccb3
chore: empty test for future canary
9809217
dummify test even more
deb71a1
fix clippy being upset
68e53a3
add migrate test into cli-integ-tets
5984f1a
integ test for CDK migrate
7b5a39e
test fixes
7c8ff72
working migrate test
07b71e4
add multi language support
6f02a66
more testing templates and update to cdk-from-cfn
d995ab9
fix go stack name issue
0772315
fix package.json version issue
a92fc50
csharp has too many stacks in it's name
2529935
modify cdk-from-cfn package versions
42cd312
typescript does PEMDAS weirdly
046bd4d
modify init template for csharp
f2740e4
Merge branch 'main' into bobertzh/testing
HBobertz a7aabde
add 0.23.0 to yarn lock
0bfabe2
fix THIRD_PARTY_LICENSCES
db85102
remove random whitespace
01e1c62
modify Third party licensces in alpha lib
dd43de7
Merge branch 'main' into bobertzh/testing
HBobertz 3b4d9ca
Merge branch 'main' into bobertzh/testing
HBobertz 9b1cb62
fix unit tests for new cdk-from-cfn version
70768d5
Conditionally add csharp stack name
321c23e
update S3Stack.cs snapshot
3144267
stackname and namespace should include stack
0ebb6f4
update to 0.27.0
25f91ed
Merge branch 'main' into bobertzh/testing
HBobertz b8d033b
add 0.27.0 to yarn lock
7883cdb
Merge branch 'main' into bobertzh/testing
HBobertz 31feecb
Delete packages/@aws-cdk-testing/cli-integ/resources/templates/autosc…
TheRealAmazonKendra d4d4dcc
Delete packages/@aws-cdk-testing/cli-integ/resources/templates/simple…
TheRealAmazonKendra eb7842e
Merge branch 'main' into bobertzh/testing
TheRealAmazonKendra 924fe5c
Merge branch 'main' into bobertzh/testing
TheRealAmazonKendra 3dea05a
python needs to install requirements
TheRealAmazonKendra ad6daea
make cli available
TheRealAmazonKendra cd74b8a
only use one fixture
TheRealAmazonKendra 69c5632
Merge branch 'main' into bobertzh/testing
mergify[bot] 0e8bdb1
remove imports
TheRealAmazonKendra fef88d6
use codebuild pip instead of venv
TheRealAmazonKendra 474713c
just troubleshooting
TheRealAmazonKendra 5ac289a
more troubleshooting
TheRealAmazonKendra bdaaffb
fix test
TheRealAmazonKendra b13a080
fix path
TheRealAmazonKendra 0c6770d
wrong path
TheRealAmazonKendra f319e9c
kendra is dumb
TheRealAmazonKendra b6aa7ec
remove test updates and only update init
TheRealAmazonKendra 385232a
Merge branch 'main' into bobertzh/testing
TheRealAmazonKendra 52d024b
Merge branch 'main' into bobertzh/testing
mergify[bot] File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -173,6 +173,8 @@ export class InitTemplate { | |
} | ||
return template.replace(/%name%/g, project.name) | ||
.replace(/%stackname%/, project.stackName ?? '%name.PascalCased%Stack') | ||
.replace(/%PascalNameSpace%/, project.stackName ? camelCase(project.stackName + 'Stack', { pascalCase: true }) : '%name.PascalCased%') | ||
.replace(/%PascalStackProps%/, project.stackName ? (camelCase(project.stackName, { pascalCase: true }) + 'StackProps') : 'StackProps') | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Same comment as last review on this line. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Same comment as above |
||
.replace(/%name\.camelCased%/g, camelCase(project.name)) | ||
.replace(/%name\.PascalCased%/g, camelCase(project.name, { pascalCase: true })) | ||
.replace(/%cdk-version%/g, cdkVersion) | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As previously mentioned, the stack props name should not be changed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
They should as it is our documented best practice for csharp: https://docs.aws.amazon.com/cdk/v2/guide/stack_how_to_create_multiple_stacks.html#cdk-how-to-create-multiple-stacks-extend-stackprops