Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(custom-resources): cannot set logging for state machine generated in CompleteHandler #27310

Merged
merged 64 commits into from
Dec 20, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
64 commits
Select commit Hold shift + click to select a range
c7d5edf
fix(custom-resources): StateMachine for isCompleteHandler in provider…
go-to-k Sep 27, 2023
5fddc2b
change codes and integ
go-to-k Sep 27, 2023
f20e343
Revert "change codes and integ"
go-to-k Sep 27, 2023
d798bf7
Merge branch 'main' of https://github.com/go-to-k/aws-cdk into fix/cu…
go-to-k Sep 27, 2023
256b91b
fix: waiter-state-machine
go-to-k Sep 27, 2023
1fe40cc
change integ tests
go-to-k Sep 27, 2023
ce58bdc
change property name and fix unit tests
go-to-k Sep 27, 2023
1b4ec5f
change name to disableWaiterStateMachineLogging
go-to-k Sep 27, 2023
7da8364
change index for export
go-to-k Sep 27, 2023
6c941e9
change import order
go-to-k Sep 27, 2023
a14775f
add docstring
go-to-k Sep 28, 2023
9f7c0f8
change props for logs and integ tests
go-to-k Sep 28, 2023
e8dcfd7
add default for destination
go-to-k Sep 28, 2023
1755f07
change doc
go-to-k Sep 28, 2023
c60d5f4
change other doc
go-to-k Sep 28, 2023
3b6da20
change aws-eks/test/integ.alb-controller
go-to-k Sep 29, 2023
bbe0fe4
aws-dynamodb/test/integ.global.js
go-to-k Sep 29, 2023
b9c5fda
integ for aws-dynamodb/test/integ.global-replicas-provisioned.js
go-to-k Sep 29, 2023
bd9f44b
integ.eks-cluster-private-endpoint.js.snapshot
go-to-k Sep 30, 2023
d674127
integ.eks-bottlerocket-ng.js.snapshot
go-to-k Sep 30, 2023
1b00eb2
rest for integ.eks-cluster-private-endpoint.js.snapshot
go-to-k Sep 30, 2023
9b0e7e4
rest for integ.eks-bottlerocket-ng.js.snapshot
go-to-k Sep 30, 2023
5f96f54
integ.eks-cluster-handlers-vpc-aws-cdk-eks-handlers-in-vpc
go-to-k Sep 30, 2023
beb5d60
add integs for fargate-cluster and eks-windows-ng
go-to-k Sep 30, 2023
1c7e988
integ.call.js.snapshot
go-to-k Sep 30, 2023
83039d8
integ.job-submission-workflow.js.snapshot
go-to-k Sep 30, 2023
09e05dc
test/emrcontainers/integ.start-job-run.js.snapshot
go-to-k Sep 30, 2023
d1a6cc6
fix a test using docker and npm
go-to-k Sep 30, 2023
58b08d3
integ.eks-service-account-sdk-call
go-to-k Sep 30, 2023
1a4a7e5
fix typo for doc in aws-cdk-lib/aws-eks/lib/k8s-manifest.ts
go-to-k Sep 30, 2023
69dde5d
add url in waiter-state-machine
go-to-k Sep 30, 2023
8be78f3
test for integ.eks-cluster.js.snapshot template
go-to-k Oct 1, 2023
a25cb4b
Revert "test for integ.eks-cluster.js.snapshot template"
go-to-k Oct 1, 2023
18f72fc
test/integ.eks-helm-asset
go-to-k Oct 5, 2023
767dd40
test/integ.eks-cluster-imported
go-to-k Oct 5, 2023
5a68fa5
test/integ.eks-cluster
go-to-k Oct 5, 2023
aca913d
test/integ.eks-cluster-ipv6
go-to-k Oct 6, 2023
67114ab
packages/@aws-cdk/aws-amplify-alpha/test/integ.app-asset-deployment.j…
go-to-k Oct 6, 2023
23e23c0
test/integ.eks-inference.js.snapshot
go-to-k Oct 6, 2023
893dff2
Merge branch 'main' into fix/custom-resource-provider-statemachine
go-to-k Oct 6, 2023
48dbb49
Merge branch 'main' into fix/custom-resource-provider-statemachine
go-to-k Oct 18, 2023
6932cb4
change integ.global and integ.global-replicas-provisioned in aws-dyna…
go-to-k Oct 18, 2023
3ebccbd
change without integ tests by review
go-to-k Oct 27, 2023
b80f7c7
change unit tests
go-to-k Oct 27, 2023
494e381
add a new integ test
go-to-k Oct 27, 2023
40be425
change integ tests integ.global and integ.global-replicas-provisioned
go-to-k Oct 27, 2023
b8a495b
update waiter-state-machine.ts for default
go-to-k Oct 27, 2023
d2c9211
update waiter-state-machine.ts
go-to-k Oct 27, 2023
63b60f3
chore: Dockerfile version to alpine3.18
go-to-k Oct 30, 2023
74e2d90
Merge branch 'main' into fix/custom-resource-provider-statemachine
go-to-k Nov 4, 2023
a6311b5
Merge branch 'main' into fix/custom-resource-provider-statemachine
go-to-k Nov 6, 2023
b27e221
Merge branch 'main' of https://github.com/go-to-k/aws-cdk into fix/cu…
go-to-k Nov 12, 2023
e10707b
Merge branch 'main' of https://github.com/go-to-k/aws-cdk into fix/cu…
go-to-k Nov 12, 2023
30136be
Merge branch 'main'
go-to-k Nov 16, 2023
313e3d9
change integ snap shots for aws-amplify-alpha
go-to-k Nov 16, 2023
b0be805
change integ test snapshots for emrcontainers/integ.start-job-run
go-to-k Nov 16, 2023
18d4f33
Merge branch 'main'
go-to-k Nov 22, 2023
e2de141
change integ.provider-with-waiter-state-machine snapshot
go-to-k Nov 22, 2023
676f877
Merge branch 'main' of https://github.com/go-to-k/aws-cdk into fix/cu…
go-to-k Nov 30, 2023
cf76b87
update snapshot for integ.provider-with-waiter-state-machine
go-to-k Nov 30, 2023
dfa7771
Merge branch 'main' into fix/custom-resource-provider-statemachine
kaizencc Dec 19, 2023
7163c86
modify docs by review
go-to-k Dec 20, 2023
ca92b3c
change snapshots
go-to-k Dec 20, 2023
0e7aeb9
Merge branch 'main' into fix/custom-resource-provider-statemachine
mergify[bot] Dec 20, 2023
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
  •  
  •  
  •  

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Original file line number Diff line number Diff line change
Expand Up @@ -291,7 +291,7 @@
{
"Fn::Sub": "cdk-hnb659fds-assets-${AWS::AccountId}-${AWS::Region}"
},
"/fac70c98815617bfec29fd3dc3b0a9295dba41bc56daf65deb4ecd6b3a35873d.json"
"/21276ea69a4912841ecedfb3a8e1b30a5f4c6414c47885941a6d7b73ba42b5a0.json"
]
]
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -676,6 +676,22 @@
]
}
]
},
{
"Action": [
"logs:CreateLogDelivery",
"logs:CreateLogStream",
"logs:DeleteLogDelivery",
"logs:DescribeLogGroups",
"logs:DescribeResourcePolicies",
"logs:GetLogDelivery",
"logs:ListLogDeliveries",
"logs:PutLogEvents",
"logs:PutResourcePolicy",
"logs:UpdateLogDelivery"
],
"Effect": "Allow",
"Resource": "*"
}
],
"Version": "2012-10-17"
Expand All @@ -688,6 +704,14 @@
]
}
},
"ProviderwaiterstatemachineLogGroupDD693A98": {
"Type": "AWS::Logs::LogGroup",
"Properties": {
"RetentionInDays": 731
},
"UpdateReplacePolicy": "Retain",
"DeletionPolicy": "Retain"
},
"Providerwaiterstatemachine5D4A9DF0": {
"Type": "AWS::StepFunctions::StateMachine",
"Properties": {
Expand All @@ -713,6 +737,22 @@
]
]
},
"LoggingConfiguration": {
"Destinations": [
{
"CloudWatchLogsLogGroup": {
"LogGroupArn": {
"Fn::GetAtt": [
"ProviderwaiterstatemachineLogGroupDD693A98",
"Arn"
]
}
}
}
],
"IncludeExecutionData": false,
"Level": "ERROR"
},
"RoleArn": {
"Fn::GetAtt": [
"ProviderwaiterstatemachineRole0C7159F9",
Expand Down

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Original file line number Diff line number Diff line change
Expand Up @@ -246,7 +246,7 @@
{
"Fn::Sub": "cdk-hnb659fds-assets-${AWS::AccountId}-eu-west-1"
},
"/fa797e339f4708c4396c4b321b5c32d871a3392d5baced2d17a9b8ad742e5c0b.json"
"/6c69eb6457ed35d3a037f058b41a894f3117b76072075e95d89efb46377b6ca5.json"
]
]
}
Expand Down

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading