Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(s3-deployment): dataJson should be jsonData #27357

Merged
merged 2 commits into from
Oct 2, 2023
Merged

docs(s3-deployment): dataJson should be jsonData #27357

merged 2 commits into from
Oct 2, 2023

Conversation

mtfurlan
Copy link
Contributor

The aws_s3_deployment.Source has jsonData and yamlData, but one of the
comments that generates documentation says dataJson and dataYaml, which
don't exist.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@mtfurlan
docs(s3 deployment source): fix dataJson -> jsonData
440bcef 
The aws_s3_deployment.Source has jsonData and yamlData, but one of the
comments that generates documentation says dataJson and dataYaml, which
don't exist.
@github-actions github-actions bot added the p2 label Sep 29, 2023
@aws-cdk-automation aws-cdk-automation requested a review from a team September 29, 2023 16:09
@github-actions github-actions bot added the beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK label Sep 29, 2023
aws-cdk-automation
aws-cdk-automation previously requested changes Sep 29, 2023
View reviewed changes
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

@mtfurlan mtfurlan changed the title docs(s3 deployment source): fix dataJson -> jsonData docs(s3 deployment source): dataJson should be jsonData Sep 29, 2023
@mtfurlan mtfurlan changed the title docs(s3 deployment source): dataJson should be jsonData docs(aws-s3-deployment/): dataJson should be jsonData Sep 29, 2023
@mtfurlan mtfurlan changed the title docs(aws-s3-deployment/): dataJson should be jsonData docs(s3-deployment/): dataJson should be jsonData Sep 29, 2023
@mtfurlan mtfurlan changed the title docs(s3-deployment/): dataJson should be jsonData docs(s3-deployment): dataJson should be jsonData Sep 29, 2023
@aws-cdk-automation aws-cdk-automation dismissed their stale review September 29, 2023 16:25

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

@aws-cdk-automation aws-cdk-automation added the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Sep 29, 2023
lpizzinidev
lpizzinidev approved these changes Sep 30, 2023
View reviewed changes
Copy link
Contributor

@lpizzinidev lpizzinidev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch 😎

@aws-cdk-automation aws-cdk-automation added pr/needs-maintainer-review This PR needs a review from a Core Team Member and removed pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. labels Sep 30, 2023
@github-actions github-actions bot mentioned this pull request Oct 1, 2023
Closed
@mergify
Copy link
Contributor

mergify bot commented Oct 2, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation aws-cdk-automation removed the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Oct 2, 2023
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: aefaf85
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit a367d91 into aws:main Oct 2, 2023
12 checks passed
@mergify
Copy link
Contributor

mergify bot commented Oct 2, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mtfurlan mtfurlan deleted the docs/s3deployment-source-jsondata-name-fix branch February 28, 2024 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kaizencc kaizencc kaizencc approved these changes

@lpizzinidev lpizzinidev lpizzinidev approved these changes

@aws-cdk-automation aws-cdk-automation aws-cdk-automation left review comments

Assignees
No one assigned
Labels
beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK p2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mtfurlan @aws-cdk-automation @lpizzinidev @kaizencc