Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(appconfig): add deploy method to configuration constructs #28174
feat(appconfig): add deploy method to configuration constructs #28174
Changes from 1 commit
5f1030b
9b1e2c8
540b3c4
2c37eb7
38c3adf
147420e
80be312
1cd58e0
670fb61
4595c86
a069c89
cfcbc59
94be576
1714db2
707f94a
55a1511
df9c622
d045bd7
f3a7744
67d9d27
0d5ea8e
a822559
185d1e8
9bacdfc
dd59233
fb64d5b
fa2481a
09d882c
d36092f
9cb2b9f
19ec804
02990fd
d13557f
995beb1
9aa0377
37cac37
a85e058
b2e1c89
9482952
562ce9b
8ea14d9
93ddf2b
03e3684
ce5244e
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should use this function to create the deployment in deployConfigToEnvironments as well to avoid code repetitions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hm yeah I had this change, but it wouldn't allow this naming convention because the
deployTo
object already existsThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Didn't see the edit on the comment above.
deployConfigToEnvironments
has different behavior and shouldn't be used here. I can however create another method to reference to avoid the duplicate code.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you please add unit tests for:
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.