Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(glue-alpha): support observability metrics for glue jobs #28193

Closed

Conversation

cbcoutinho
Copy link

AWS Glue jobs support publishing observability metrics. This PR enables this feature in aws-glue-alpha.

https://docs.aws.amazon.com/glue/latest/dg/monitor-observability.html


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@aws-cdk-automation aws-cdk-automation requested a review from a team November 29, 2023 22:20
@github-actions github-actions bot added p2 beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK labels Nov 29, 2023
@aws-cdk-automation aws-cdk-automation added the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Nov 29, 2023
Copy link
Contributor

@go-to-k go-to-k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution!

And, could you please change the PR title to feat(glue-alpha): support observability metrics for glue jobs?

This is because this is a fine feature addition. Also, lower case is good except for proper nouns. (see the statement Title should be lowercase. in the contribution guide)

Then, in the case for the feat, you must add the snapshots for the integ tests and update README. As for the integ test, it is necessary to make additions to existing integ tests or create new tests, and commit the snapshot that is the result of the execution.

https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md#integration-tests
https://github.com/aws/aws-cdk/blob/main/INTEGRATION_TESTS.md

If you decide that there is nothing in particular to write in the README, comment Exemption Request. (e.g. Exemption Request: ...reason...)

packages/@aws-cdk/aws-glue-alpha/lib/job.ts Outdated Show resolved Hide resolved
@aws-cdk-automation aws-cdk-automation removed the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Nov 30, 2023
You are correct, thanks

Co-authored-by: k.goto <24818752+go-to-k@users.noreply.github.com>
@cbcoutinho cbcoutinho changed the title chore(glue-alpha): Enable observability metrics in Glue Jobs feat(glue-alpha): support observability metrics for glue jobs Nov 30, 2023
@cbcoutinho
Copy link
Author

Thanks for the contribution!

And, could you please change the PR title to feat(glue-alpha): support observability metrics for glue jobs?

This is because this is a fine feature addition. Also, lower case is good except for proper nouns. (see the statement Title should be lowercase. in the contribution guide)

Then, in the case for the feat, you must add the snapshots for the integ tests and update README. As for the integ test, it is necessary to make additions to existing integ tests or create new tests, and commit the snapshot that is the result of the execution.

https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md#integration-tests https://github.com/aws/aws-cdk/blob/main/INTEGRATION_TESTS.md

If you decide that there is nothing in particular to write in the README, comment Exemption Request. (e.g. Exemption Request: ...reason...)

Thanks for the feedback. I've accepted the contribution - I'll get back to you regarding the tests

@aws-cdk-automation aws-cdk-automation added the pr-linter/exemption-requested The contributor has requested an exemption to the PR Linter feedback. label Nov 30, 2023
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

@aws-cdk-automation
Copy link
Collaborator

The pull request linter fails with the following errors:

❌ Features must contain a change to a README file.
❌ Features must contain a change to an integration test file and the resulting snapshot.

PRs must pass status checks before we can provide a meaningful review.

If you would like to request an exemption from the status checks or clarification on feedback, please leave a comment on this PR containing Exemption Request and/or Clarification Request.

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 9fecc34
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@kaizencc
Copy link
Contributor

FYI: we're in the process of revamping the glue module, which is why I haven't been approving any glue PRs lately. Please bear with us a bit longer, I'm trying to see if we can get the green light to continue to merge quality-of-life PRs in the meantime.

@cbcoutinho
Copy link
Author

Feel free to close this PR. I don't have the capacity to add tests for the foreseeable future, and anyone who needs this feature flag can just add it manually

@cbcoutinho cbcoutinho closed this Dec 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK p2 pr-linter/exemption-requested The contributor has requested an exemption to the PR Linter feedback.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants