-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(rds): Add logRetentions property to clusters and instances #28218
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.
A comment requesting an exemption should contain the text Exemption Request
. Additionally, if clarification is needed add Clarification Request
to a comment.
Exemption Request: I could not find any existing integration tests. Please let me know in case I missed something. |
@snaksa The RDS integ tests live here https://github.com/aws/aws-cdk/tree/main/packages/%40aws-cdk-testing/framework-integ/test/aws-rds/test ! This looks good, a couple integ tests and we should be good to go. |
@scanlonp Does this change need an integration test? It just exposes the generated |
The pull request linter fails with the following errors:
PRs must pass status checks before we can provide a meaningful review. If you would like to request an exemption from the status checks or clarification on feedback, please leave a comment on this PR containing |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Add a
logRetentions
property to the Cluster and Instance objects to be able to get the generated CloudWatch LogGroup ARN. The type of the field is{[key:string]: logs.LogRetention}
and allows accessing the LogGroup for a certain log type provided through thecloudwatchLogsExports
property.Closes #20358.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license