Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ecs-patterns): taskDefinition ignored by queueProcessingFargateService #28220

Merged
merged 18 commits into from
Dec 19, 2023
Merged

fix(ecs-patterns): taskDefinition ignored by queueProcessingFargateService #28220

merged 18 commits into from
Dec 19, 2023

Conversation

badmintoncryer
Copy link
Contributor

@badmintoncryer badmintoncryer commented Dec 1, 2023 •
edited
Loading

Fixed a bug in queueProcessingFargateService where the taskDefinition provided as an argument was not being used, and a default taskDefinition was always being generated instead.

Closes #27360

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@github-actions github-actions bot added the beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK label Dec 1, 2023
@aws-cdk-automation aws-cdk-automation requested a review from a team December 1, 2023 15:05
@github-actions github-actions bot added bug This issue is a bug. effort/small Small work item – less than a day of effort p2 labels Dec 1, 2023
aws-cdk-automation
aws-cdk-automation previously requested changes Dec 1, 2023
View reviewed changes
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

@badmintoncryer badmintoncryer changed the title fix(aws-ecs-patterns): Specified taskDefinition was not utilized in queue-processing-fargate-service fix(ecs-patterns): Specified taskDefinition was not utilized in queue-processing-fargate-service Dec 1, 2023
@badmintoncryer badmintoncryer marked this pull request as draft December 2, 2023 04:48
@aws-cdk-automation aws-cdk-automation dismissed their stale review December 9, 2023 13:32

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

@badmintoncryer badmintoncryer marked this pull request as ready for review December 10, 2023 04:05
@badmintoncryer badmintoncryer marked this pull request as draft December 10, 2023 04:06
@badmintoncryer badmintoncryer marked this pull request as ready for review December 10, 2023 04:17
@badmintoncryer
Copy link
Contributor Author

badmintoncryer commented Dec 10, 2023 •
edited
Loading

In QueueProcessingServiceBaseProps, the image is defined and this is inherited by both QueueProcessingEc2ServiceProps and QueueProcessingFargateServiceProps.

Here, I want to make the image mandatory for QueueProcessingEc2ServiceProps, but optional for QueueProcessingFargateServiceProps.

Currently, the definition in QueueProcessingServiceBaseProps is set as optional, and in QueueProcessingEc2Service, a check for props.image != null is being performed.

Is this approach acceptable? Please advise if there is a more preferable approach.

@badmintoncryer badmintoncryer changed the title fix(ecs-patterns): Specified taskDefinition was not utilized in queue-processing-fargate-service fix(ecs-patterns): Specified taskDefinition was not utilized in queueProcessingFargateService Dec 10, 2023
@aws-cdk-automation aws-cdk-automation added the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Dec 10, 2023
lpizzinidev
lpizzinidev suggested changes Dec 11, 2023
View reviewed changes
Copy link
Contributor

@lpizzinidev lpizzinidev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution! 👍
Looks good overall, I left some comments for some cleanup and missing test cases.
Suggestion for title: fix(ecs-patterns): taskDefinition ignored by queueProcessingFargateService.

packages/aws-cdk-lib/aws-ecs-patterns/lib/fargate/queue-processing-fargate-service.ts Outdated Show resolved Hide resolved
packages/aws-cdk-lib/aws-ecs-patterns/test/fargate/queue-processing-fargate-service.test.ts Show resolved Hide resolved
packages/aws-cdk-lib/aws-ecs-patterns/lib/ecs/queue-processing-ecs-service.ts Outdated Show resolved Hide resolved
packages/aws-cdk-lib/aws-ecs-patterns/lib/base/queue-processing-service-base.ts Outdated Show resolved Hide resolved
@aws-cdk-automation aws-cdk-automation removed the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Dec 11, 2023
@badmintoncryer badmintoncryer changed the title fix(ecs-patterns): Specified taskDefinition was not utilized in queueProcessingFargateService fix(ecs-patterns): taskDefinition ignored by queueProcessingFargateService Dec 11, 2023
lpizzinidev
lpizzinidev suggested changes Dec 11, 2023
View reviewed changes
Copy link
Contributor

@lpizzinidev lpizzinidev left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 👍
I forgot to add backticks on the documentation during the first review, sorry for that.
If you could please fix it then this will be good to go for me.

packages/aws-cdk-lib/aws-ecs-patterns/lib/base/queue-processing-service-base.ts Outdated Show resolved Hide resolved
badmintoncryer and others added 6 commits December 12, 2023 01:10
@badmintoncryer
fix: queue-processing-fargate-service.test.ts
d516b15
@badmintoncryer @lpizzinidev
Update packages/aws-cdk-lib/aws-ecs-patterns/lib/fargate/queue-proces…
a5de76b 
…sing-fargate-service.ts

Co-authored-by: Luca Pizzini <lpizzini7@gmail.com>
@badmintoncryer @lpizzinidev
Update packages/aws-cdk-lib/aws-ecs-patterns/lib/ecs/queue-processing…
0c999c9 
…-ecs-service.ts

Co-authored-by: Luca Pizzini <lpizzini7@gmail.com>
@badmintoncryer @lpizzinidev
Update packages/aws-cdk-lib/aws-ecs-patterns/lib/base/queue-processin…
0d60283 
…g-service-base.ts

Co-authored-by: Luca Pizzini <lpizzini7@gmail.com>
@badmintoncryer
test: add test
296c136
@badmintoncryer @lpizzinidev
Update packages/aws-cdk-lib/aws-ecs-patterns/lib/base/queue-processin…
7a29244 
…g-service-base.ts

Co-authored-by: Luca Pizzini <lpizzini7@gmail.com>
@aws-cdk-automation aws-cdk-automation added the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Dec 11, 2023
sumupitchayan
sumupitchayan previously approved these changes Dec 19, 2023
View reviewed changes
@sumupitchayan sumupitchayan self-assigned this Dec 19, 2023
@mergify mergify bot dismissed sumupitchayan’s stale review December 19, 2023 21:26

Pull request has been modified.

@aws-cdk-automation aws-cdk-automation removed the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Dec 19, 2023
@mergify Mergify
Copy link
Contributor

mergify bot commented Dec 19, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 48a987f
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit 5d6b8ee into aws:main Dec 19, 2023
9 checks passed
@mergify Mergify
Copy link
Contributor

mergify bot commented Dec 19, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@badmintoncryer badmintoncryer deleted the fixEcs branch December 20, 2023 01:15
@github-actions github-actions bot mentioned this pull request Jan 1, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sumupitchayan sumupitchayan sumupitchayan approved these changes

@lpizzinidev lpizzinidev lpizzinidev approved these changes

@aws-cdk-automation aws-cdk-automation aws-cdk-automation left review comments

Assignees

@sumupitchayan sumupitchayan

Labels
beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK bug This issue is a bug. effort/small Small work item – less than a day of effort p2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

aws-ecs-patterns: taskDefinition prop ignored on QueueProcessingFargateService
4 participants
@badmintoncryer @aws-cdk-automation @lpizzinidev @sumupitchayan