Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(apigatewayv2-alpha): delete alpha module #28228

Merged
merged 10 commits into from
Dec 5, 2023
Merged

chore(apigatewayv2-alpha): delete alpha module #28228

merged 10 commits into from
Dec 5, 2023

Conversation

sumupitchayan
Copy link
Contributor

@sumupitchayan sumupitchayan commented Dec 1, 2023 •
edited
Loading

Deletes the aws-apigatewayv2-alpha, aws-apigatewayv2-authorizers-alpha, and aws-apigatewayv2-integrations-alpha modules since they have now been stabilized. Also removes references to these deprecated alpha modules.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@sumupitchayan
delete apigatewayv2-alpha module
0aea383 
Signed-off-by: Sumu <sumughan@amazon.com>
@github-actions github-actions bot added the p2 label Dec 1, 2023
@aws-cdk-automation aws-cdk-automation requested a review from a team December 1, 2023 19:59
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Dec 1, 2023
@sumupitchayan sumupitchayan changed the title chore(apigatewayv2): delete apigatewayv2-alpha module chore(apigatewayv2): delete alpha module Dec 1, 2023
@sumupitchayan
delete integrations and authorizers alpha modules
a1f5372 
Signed-off-by: Sumu <sumughan@amazon.com>
@sumupitchayan
remove references to alpha module
0c4facb 
Signed-off-by: Sumu <sumughan@amazon.com>
@sumupitchayan
remove alpha module jsii rosetta example dependency
4dd4b12 
Signed-off-by: Sumu <sumughan@amazon.com>
@sumupitchayan sumupitchayan changed the title chore(apigatewayv2): delete alpha module chore(apigatewayv2): delete alpha modules Dec 1, 2023
@sumupitchayan
remove notice for apigatewayv2 from notices.test.ts
c9b5729 
Signed-off-by: Sumu <sumughan@amazon.com>
@jrobbins-LiveData jrobbins-LiveData mentioned this pull request Dec 3, 2023
Closed
@aws-cdk-automation aws-cdk-automation added the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Dec 4, 2023
@vinayak-kukreja vinayak-kukreja changed the title chore(apigatewayv2): delete alpha modules chore(apigatewayv2-alpha): delete alpha module Dec 5, 2023
@vinayak-kukreja vinayak-kukreja added the pr/do-not-merge This PR should not be merged at this time. label Dec 5, 2023
@vinayak-kukreja
Copy link
Contributor

Hey are you sure this is correct?
I see you are deleting all the files of the alpha package and not marking anything as deprecated. Can you confirm with Kaizen or whomever did the latest stablization if this is what is expected?

Did you release a deprecated version of this? For instance: #27471, #27505, #27568

vinayak-kukreja
vinayak-kukreja reviewed Dec 5, 2023
View reviewed changes
packages/@aws-cdk/aws-apigatewayv2-alpha/package.json
Comment on lines -104 to -105
"stability": "deprecated",
"maturity": "deprecated",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ohh, I do see this was deprecated. I am ok with approving this if you have followed the stablization template.

vinayak-kukreja
vinayak-kukreja approved these changes Dec 5, 2023
View reviewed changes
Copy link
Contributor

@vinayak-kukreja vinayak-kukreja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Synced offline. Thanks Sumu 🎉

@aws-cdk-automation aws-cdk-automation removed the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Dec 5, 2023
@vinayak-kukreja vinayak-kukreja removed the pr/do-not-merge This PR should not be merged at this time. label Dec 5, 2023
@mergify Mergify
Copy link
Contributor

mergify bot commented Dec 5, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 7c8c285
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit 8622ee8 into main Dec 5, 2023
13 checks passed
@mergify mergify bot deleted the sumughan/deprecate-apigatewayv2-alpha branch December 5, 2023 21:17
@mergify Mergify
Copy link
Contributor

mergify bot commented Dec 5, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@go-to-k
Copy link
Contributor

go-to-k commented Dec 6, 2023

@sumupitchayan @vinayak-kukreja

Why was the README for aws-stepfunctions-tasks removed? Is this not a mistake?

https://github.com/aws/aws-cdk/pull/28228/files#diff-47dc23b45ad9af4f4332c4b680427f8f0f66e216422048a4a7771d21c1cc4326

I have submitted a PR to restore the README, if this is not necessary, please let me know.

#28272

@github-actions github-actions bot mentioned this pull request Jan 1, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vinayak-kukreja vinayak-kukreja vinayak-kukreja approved these changes

Assignees
No one assigned
Labels
contribution/core This is a PR that came from AWS. p2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sumupitchayan @vinayak-kukreja @aws-cdk-automation @go-to-k