Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(eks): Allow atomic flag for helm chart #28337

Closed
wants to merge 4 commits into from
Closed

feat(eks): Allow atomic flag for helm chart #28337

wants to merge 4 commits into from

Conversation

alexandersperling
Copy link
Contributor

@alexandersperling alexandersperling commented Dec 12, 2023 •
edited
Loading

This PR adds the possibilty to use the atomic flag for helm charts.

Basically I took code from an PR which was closed sometime ago, and refactored it.

Add atomic flag for helm chart construct
Update unit test
Update README

Closes #22254

@alexandersperling
feat(aws-eks): Allow atomic flag for helm chart
d98088c 
* Add atomic flag for helm chart construct
* Update unit test
* Update README
@github-actions github-actions bot added beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. p2 labels Dec 12, 2023
@aws-cdk-automation aws-cdk-automation requested a review from a team December 12, 2023 10:02
aws-cdk-automation
aws-cdk-automation requested changes Dec 12, 2023
View reviewed changes
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

@alexandersperling alexandersperling changed the title feat(aws-eks): Allow atomic flag for helm chart feat(eks): Allow atomic flag for helm chart Dec 12, 2023
@alexandersperling
Copy link
Contributor Author

Clarification Request - I added an integration test case but when running this test it fails with an error for the 'non ecr oci chart' test case.

Bildschirmfoto 2023-12-13 um 10 32 34

How can this be fixed or could someone run this integration test?

@aws-cdk-automation aws-cdk-automation added the pr/reviewer-clarification-requested The contributor has requested clarification on feedback, a failing build, or a failing PR Linter run label Dec 13, 2023
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 5443639
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@sumupitchayan
Copy link
Contributor

@alexandersperling the integ also failed when I tried running it. Are you sure that this change is supported by EKS / CloudFormation?

@alexandersperling
Copy link
Contributor Author

@sumupitchayan I'm not sure, usually the integ test should show. Unfortunately it fails on a prior test already so that we can not see the result of the new one.

@github-actions github-actions bot mentioned this pull request Jan 1, 2024
Closed
@aws-cdk-automation
Copy link
Collaborator

This PR has been in the CHANGES REQUESTED state for 3 weeks, and looks abandoned. To keep this PR from being closed, please continue work on it. If not, it will automatically be closed in a week.

@aws-cdk-automation
Copy link
Collaborator

This PR has been deemed to be abandoned, and will be automatically closed. Please create a new PR for these changes if you think this decision has been made in error.

@aws-cdk-automation aws-cdk-automation added the closed-for-staleness This issue was automatically closed because it hadn't received any attention in a while. label Jan 10, 2024
@aws-cdk-automation
Copy link
Collaborator

The pull request linter fails with the following errors:

❌ Features must contain a change to an integration test file and the resulting snapshot.

PRs must pass status checks before we can provide a meaningful review.

If you would like to request an exemption from the status checks or clarification on feedback, please leave a comment on this PR containing Exemption Request and/or Clarification Request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aws-cdk-automation aws-cdk-automation aws-cdk-automation requested changes

Assignees
No one assigned
Labels
beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK closed-for-staleness This issue was automatically closed because it hadn't received any attention in a while. effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. p2 pr/reviewer-clarification-requested The contributor has requested clarification on feedback, a failing build, or a failing PR Linter run
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

aws-eks: support --atomic flag for helm commands
3 participants
@alexandersperling @aws-cdk-automation @sumupitchayan