-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: add $or operator to the EventPattern interface #28368
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.
A comment requesting an exemption should contain the text Exemption Request
. Additionally, if clarification is needed add Clarification Request
to a comment.
✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.
771e721
to
f223017
Compare
The error seeing now is:
I wonder if there is a way to avoid this? Or can |
f223017
to
564a335
Compare
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see the docs that say "Comparison operators only work on leaf nodes, with the exception of $or and anything-but." so I'm willing to entertain this. This PR needs:
- the property can't be named
$or
. This really means 'anyOf' right? Lets name it that - integ test demonstrating that we can use this property at the root level.
This PR has been in the BUILD FAILING state for 3 weeks, and looks abandoned. To keep this PR from being closed, please continue work on it. If not, it will automatically be closed in a week. |
This PR has been deemed to be abandoned, and will be automatically closed. Please create a new PR for these changes if you think this decision has been made in error. |
This PR adds a missing
$or
comparison operator to the EventPattern interface. As describe in the doc the$or
is not limited to only be on the leaf-node.Before this change the TS compiler would throw
Object literal may only specify known properties, and '$or' does not exist in type 'EventPattern'
Error. By adding// @ts-ignore
one could get ride of the TS error and the code/rule would work as expected.With this change the TS compiler no longer raises this error and
$or
is an excepted property on the EventPattern interface.Integration test was not run.
It is uncertain what prefix should have been used for this PR. Is Fix. more accurate?
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license