Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(pipes): EventBridge Pipes alpha module #28388

Merged
merged 43 commits into from
Jan 30, 2024
Merged

feat(pipes): EventBridge Pipes alpha module #28388

merged 43 commits into from
Jan 30, 2024

Conversation

RaphaelManke
Copy link
Contributor

@RaphaelManke RaphaelManke commented Dec 15, 2023 •
edited by mrgrain
Loading

This PR is the starting point of the implementation for a L2 construct as defined in aws/aws-cdk-rfcs#473

In this PR the basic Pipe class is introduced including the api interfaces for how to define a pipe.

Closes #23495

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@github-actions github-actions bot added beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK p2 labels Dec 15, 2023
@aws-cdk-automation aws-cdk-automation requested a review from a team December 15, 2023 17:17
@github-actions github-actions bot added effort/large Large work item – several weeks of effort feature-request A feature should be added or improved. p1 and removed p2 labels Dec 15, 2023
aws-cdk-automation
aws-cdk-automation previously requested changes Dec 15, 2023
View reviewed changes
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

@RaphaelManke RaphaelManke changed the title feat(pipe): add EventBridge Pipe L2 alpha module feat(pipes): add EventBridge Pipe L2 alpha module Dec 15, 2023
@RaphaelManke RaphaelManke changed the title feat(pipes): add EventBridge Pipe L2 alpha module feat(pipes): add EventBridge Pipes alpha module Dec 15, 2023
@aws-cdk-automation aws-cdk-automation dismissed their stale review December 17, 2023 18:58

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

@RaphaelManke RaphaelManke force-pushed the raphaelmanke/rfc-473-eventbridge-pipe branch 3 times, most recently from e919539 to c5c8dfc Compare December 19, 2023 16:06
@mrgrain mrgrain self-assigned this Dec 19, 2023
@RaphaelManke RaphaelManke force-pushed the raphaelmanke/rfc-473-eventbridge-pipe branch 2 times, most recently from a4b630a to f073603 Compare December 28, 2023 17:19
@RaphaelManke RaphaelManke marked this pull request as ready for review December 28, 2023 17:33
@aws-cdk-automation aws-cdk-automation added the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Dec 28, 2023
@mrgrain mrgrain changed the title feat(pipes): add EventBridge Pipes alpha module feat(pipes): EventBridge Pipes alpha module Dec 29, 2023
mrgrain
mrgrain reviewed Dec 29, 2023
View reviewed changes
.gitignore Outdated Show resolved Hide resolved
@RaphaelManke RaphaelManke force-pushed the raphaelmanke/rfc-473-eventbridge-pipe branch from e2c6161 to 0621a2d Compare January 28, 2024 16:52
mrgrain
mrgrain previously approved these changes Jan 29, 2024
View reviewed changes
Copy link
Contributor

@mrgrain mrgrain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@mrgrain
Copy link
Contributor

mrgrain commented Jan 29, 2024

@Mergifyio update

@mergify Mergify
Copy link
Contributor

mergify bot commented Jan 29, 2024

update

☑️ Nothing to do

  • #commits-behind>0 [📌 update requirement]
  • -closed [📌 update requirement]
  • -conflict [📌 update requirement]

@mergify mergify bot dismissed mrgrain’s stale review January 29, 2024 17:09

Pull request has been modified.

@mrgrain
Copy link
Contributor

mrgrain commented Jan 29, 2024

@Mergifyio update

@mergify Mergify
Copy link
Contributor

mergify bot commented Jan 29, 2024

update

✅ Branch has been successfully updated

@mergify Mergify
Copy link
Contributor

mergify bot commented Jan 29, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mrgrain
Copy link
Contributor

mrgrain commented Jan 30, 2024

@Mergifyio update

@mergify Mergify
Copy link
Contributor

mergify bot commented Jan 30, 2024

update

✅ Branch has been successfully updated

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 2684de3
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify Mergify
Copy link
Contributor

mergify bot commented Jan 30, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit 2d9106b into aws:main Jan 30, 2024
9 checks passed
SankyRed pushed a commit that referenced this pull request Feb 8, 2024
@RaphaelManke @SankyRed
feat(pipes): EventBridge Pipes alpha module (#28388)
a93c3b3 
This PR is the starting point of the implementation for a L2 construct as defined in aws/aws-cdk-rfcs#473

In this PR the basic Pipe class is introduced including the api interfaces for how to define a pipe. 


Closes #23495

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrgrain mrgrain mrgrain approved these changes

@aws-cdk-automation aws-cdk-automation aws-cdk-automation left review comments

Assignees

@mrgrain mrgrain

Labels
beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK effort/large Large work item – several weeks of effort feature-request A feature should be added or improved. p1 pr/needs-maintainer-review This PR needs a review from a Core Team Member
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

(pipes): Add L2 support for Amazon EventBridge Pipes
3 participants
@RaphaelManke @mrgrain @aws-cdk-automation