Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ec2): passing keypair to instance unexpectedly does nothing #28482

Merged
merged 10 commits into from
Jan 8, 2024
Merged

fix(ec2): passing keypair to instance unexpectedly does nothing #28482

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
4fe30e5
fix keypair support for ec2
ayush-shah-1501 Dec 24, 2023
ced157c
Merge branch 'main' into ec2-key-pair
ayush-shah-1501 Dec 24, 2023
4609f9d
Fix: wrong parameter
ayush-shah-1501 Dec 25, 2023
449f524
Merge branch 'main' into ec2-key-pair
ayush-shah-1501 Dec 25, 2023
f8cbdfa
Add additional tests for EC2 Instance Key Pair
laurelmay Dec 29, 2023
4ab7bcc
Merge pull request #1 from kylelaker/add-instance-unit-test
ayush-shah-1501 Dec 29, 2023
98cd06b
Merge branch 'main' into ec2-key-pair
ayush-shah-1501 Dec 29, 2023
fc4090b
Merge branch 'main' into ec2-key-pair
ayush-shah-1501 Jan 1, 2024
7800f86
Merge branch 'main' into ec2-key-pair
ayush-shah-1501 Jan 3, 2024
256455c
Merge branch 'main' into ec2-key-pair
mergify[bot] Jan 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/aws-cdk-lib/aws-ec2/lib/instance.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -437,7 +437,7 @@ export class Instance extends Resource implements IInstance {
// there is no need to configure them on the instance level
this.instance = new CfnInstance(this, 'Resource', {
imageId: imageConfig.imageId,
keyName: props.keyName,
keyName: props.keyPair?.keyPairName,
instanceType: props.instanceType.toString(),
subnetId: networkInterfaces ? undefined : subnet.subnetId,
securityGroupIds: networkInterfaces ? undefined : securityGroupsToken,
Expand Down
Loading