Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(autoscaling): datapointsToAlarm property for step scaling policy #28792

Merged
merged 12 commits into from
Jan 23, 2024
Merged

feat(autoscaling): datapointsToAlarm property for step scaling policy #28792

merged 12 commits into from
Jan 23, 2024

Conversation

go-to-k
Copy link
Contributor

@go-to-k go-to-k commented Jan 20, 2024 •
edited
Loading

This PR adds a property datapointsToAlarm for StepScalingPolicy.

Closes #28749.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@aws-cdk-automation aws-cdk-automation requested a review from a team January 20, 2024 13:37
@github-actions github-actions bot added effort/medium Medium work item – several days of effort feature-request A feature should be added or improved. p2 distinguished-contributor [Pilot] contributed 50+ PRs to the CDK labels Jan 20, 2024
@go-to-k go-to-k changed the title feat(autoscaling): property for step scaling policy feat(autoscaling): datapointsToAlarm property for step scaling policy Jan 20, 2024
aws-cdk-automation
aws-cdk-automation previously requested changes Jan 20, 2024
View reviewed changes
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

@aws-cdk-automation aws-cdk-automation dismissed their stale review January 20, 2024 14:39

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

@go-to-k go-to-k marked this pull request as ready for review January 20, 2024 14:41
@aws-cdk-automation aws-cdk-automation added the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Jan 20, 2024
lpizzinidev
lpizzinidev suggested changes Jan 20, 2024
View reviewed changes
Copy link
Contributor

@lpizzinidev lpizzinidev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 👍
I left some notes for minor adjustments.

packages/aws-cdk-lib/aws-autoscaling/test/scaling.test.ts Outdated Show resolved Hide resolved
packages/aws-cdk-lib/aws-autoscaling/lib/step-scaling-policy.ts Outdated Show resolved Hide resolved
packages/aws-cdk-lib/aws-autoscaling/lib/step-scaling-policy.ts Outdated Show resolved Hide resolved
@aws-cdk-automation aws-cdk-automation removed the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Jan 20, 2024
@go-to-k go-to-k requested a review from lpizzinidev January 21, 2024 05:38
@go-to-k
Copy link
Contributor Author

go-to-k commented Jan 21, 2024

@lpizzinidev

Thanks for your review. I fixed.

lpizzinidev
lpizzinidev approved these changes Jan 21, 2024
View reviewed changes
Copy link
Contributor

@lpizzinidev lpizzinidev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 👍

@aws-cdk-automation aws-cdk-automation added the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Jan 21, 2024
aaythapa
aaythapa reviewed Jan 22, 2024
View reviewed changes
Copy link
Contributor

@aaythapa aaythapa left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution! Looks good overall, some minor comments/questions

packages/aws-cdk-lib/aws-autoscaling/lib/step-scaling-policy.ts Outdated Show resolved Hide resolved
packages/aws-cdk-lib/aws-autoscaling/lib/step-scaling-policy.ts Outdated Show resolved Hide resolved
@go-to-k go-to-k requested a review from aaythapa January 23, 2024 00:40
@go-to-k
Copy link
Contributor Author

go-to-k commented Jan 23, 2024

@aaythapa

Thanks for your review. I changed.

aaythapa
aaythapa previously approved these changes Jan 23, 2024
View reviewed changes
Copy link
Contributor

@aaythapa aaythapa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@mergify Mergify
Copy link
Contributor

mergify bot commented Jan 23, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation aws-cdk-automation removed the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Jan 23, 2024
@mergify Mergify
Copy link
Contributor

mergify bot commented Jan 23, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot dismissed aaythapa’s stale review January 23, 2024 18:25

Pull request has been modified.

@mergify Mergify
Copy link
Contributor

mergify bot commented Jan 23, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 02dc332
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit baf2bfb into aws:main Jan 23, 2024
9 checks passed
@mergify Mergify
Copy link
Contributor

mergify bot commented Jan 23, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@go-to-k go-to-k mentioned this pull request Jan 26, 2024
Merged
mergify bot pushed a commit that referenced this pull request Jan 30, 2024
@go-to-k
feat(applicationautoscaling): validate evaluationPeriods and `datap…
4034adb 
…ointsToAlarm` for step scaling policy (#28880)

This PR adds validations for `evaluationPeriods` and `datapointsToAlarm` for step scaling policy. It is based on [the PR for datapointsToAlarm in autoscaling step scaling policy](#28792).

Check the following cases:
- `evaluationPeriods` < 1
- `datapointsToAlarm` is set, and
  - `evaluationPeriods` is not set
  - `datapointsToAlarm` < 1
  - `evaluationPeriods` < `datapointsToAlarm`

These validations also consider whether those parameters are tokens or not.

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
@github-actions github-actions bot mentioned this pull request Feb 1, 2024
Closed
SankyRed pushed a commit that referenced this pull request Feb 8, 2024
@go-to-k @SankyRed
feat(applicationautoscaling): validate evaluationPeriods and `datap…
2078944 
…ointsToAlarm` for step scaling policy (#28880)

This PR adds validations for `evaluationPeriods` and `datapointsToAlarm` for step scaling policy. It is based on [the PR for datapointsToAlarm in autoscaling step scaling policy](#28792).

Check the following cases:
- `evaluationPeriods` < 1
- `datapointsToAlarm` is set, and
  - `evaluationPeriods` is not set
  - `datapointsToAlarm` < 1
  - `evaluationPeriods` < `datapointsToAlarm`

These validations also consider whether those parameters are tokens or not.

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aaythapa aaythapa aaythapa approved these changes

@lpizzinidev lpizzinidev lpizzinidev approved these changes

@aws-cdk-automation aws-cdk-automation aws-cdk-automation left review comments

Assignees
No one assigned
Labels
distinguished-contributor [Pilot] contributed 50+ PRs to the CDK effort/medium Medium work item – several days of effort feature-request A feature should be added or improved. p2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AutoScalingGroup: DatapointsToAlarm property support for BasicStepScalingPolicyProps
4 participants
@go-to-k @aws-cdk-automation @lpizzinidev @aaythapa