fix(events-targets): ecs:TagResource permission #28898
Conversation
github-actions
bot
added
star-contributor
| @@ -0,0 +1,3 @@ | |||
| FROM --platform=linux/amd64 public.ecr.aws/docker/library/python:3.12 | |||
| ADD index.py . | |||
| CMD [ "python3", "./index.py" ] | |||
There was a problem hiding this comment.
this image needed to be changed. it was using a lambda image which resulted in the following:
entrypoint requires the handler name to be the first argument.
aws-cdk-automation
added
the
pr/needs-maintainer-review
|
@ConnorRobertson Any feedback on this one? |
There was a problem hiding this comment.
Hi @msambol, apologies for the delay to get around to this. The changes look good to me, just left one comment about accessing region.
Btw I just realized you're the one behind the Data structures and algorithms in X minutes videos, I'm a big fan!
Thank you for the kind words! 😄 Much appreciated. Good catch on cluster region. I updated the PR. |
aws-cdk-automation
removed
the
pr/needs-maintainer-review
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
…#29633) ### Issue # (if applicable) Closes #29610 Related to #28898 ### Reason for this change Previously the AWS partition was hardcoded so it would not work for other special partitions. ### Description of changes Replace hardcoded `aws` partition to be dynamically added with `this.cluster.stack.partition`. ### Description of how you validated changes Ran integ tests suite, no changes. ### Checklist - [x] My code adheres to the [CONTRIBUTING GUIDE](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) and [DESIGN GUIDELINES](https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md) ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
I enabled the following:
aws ecs put-account-setting-default --name tagResourceAuthorization --value onAnd then confirmed the task completes successfully.
Closes #28854.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license