-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(efs): create read-only file system for use as a destination of replication #28913
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.
A comment requesting an exemption should contain the text Exemption Request
. Additionally, if clarification is needed add Clarification Request
to a comment.
✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you once again for your contribution!
I'd suggest we use enums in this case. I understand that there are other CFN properties that take either ENABLED or DISABLED but in CDK they're boolean so this change would be consistent with that.
But in the future if CFN adds more valid values then we'll regret making this a boolean. Plus if its enums we can do a simple pass through and don't have to do any extra meddling in the code.
8d27761
to
d851c01
Compare
Thank you for the review. As you suggested, I have revised it to use the enum format. |
Pull request has been modified.
@aaythapa |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
…eplication (#28913) In this PR, I have added the `replicationOverwriteProtection` argument to the L2 construct. This enables the creation of a filesystem that can be used as a destination for replication. ```ts const fileSystem = new efs.FileSystem(this, 'MyEfsFileSystem', { vpc: new ec2.Vpc(this, 'VPC'), replicationOverwriteProtection: true, // Set to false if you want to create a read-only file system for use as a replication destination }); ``` Closes #28912. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
In this PR, I have added the
replicationOverwriteProtection
argument to the L2 construct. This enables the creation of a filesystem that can be used as a destination for replication.Closes #28912.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license