fix(integ-runner): cannot pass test name after --language
#28922
Conversation
… and experimental modules
mrgrain
changed the title
--language
There was a problem hiding this comment.
The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.
A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.
mrgrain
added
pr-linter/exempt-test
aws-cdk-automation
dismissed
their stale review
✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Current situation: yarn integ allows to run a TS integ file CI doesn’t allow it, which caused confusing issues. What we want instead: Both local integ-runner and CI don’t allow it, so that this issue won’t happen again. To do this, we need to update integ-runner to disable running TS locally. `integ-runner` package json should stay the same as it includes other tests in python and go. Had a previous attempt in this PR #28770, but reverted as it caused an issue, see detail in #28891. BREAKING CHANGE: Parsing of the cli input caused arguments passed after the first instance `--language <language>` to be interpreted as a language as well. This prevented passing a test name after providing cli options. To overcome this limitation, `integ-runner` now requires an explicit `--language` option for each language you want to include: `integ-runner --language javascript --language python`. This was already documented that way and always the intended way to use this feature. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Current situation:
yarn integ allows to run a TS integ file
CI doesn’t allow it, which caused confusing issues.
What we want instead:
Both local integ-runner and CI don’t allow it, so that this issue won’t happen again. To do this, we need to update integ-runner to disable running TS locally.
integ-runnerpackage json should stay the same as it includes other tests in python and go.Had a previous attempt in this PR #28770, but reverted as it caused an issue, see detail in #28891.
BREAKING CHANGE: Parsing of the cli input caused arguments passed after the first instance
--language <language>to be interpreted as a language as well. This prevented passing a test name after providing cli options. To overcome this limitation,integ-runnernow requires an explicit--languageoption for each language you want to include:integ-runner --language javascript --language python. This was already documented that way and always the intended way to use this feature.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license