Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(applicationautoscaling): add missing PredefinedMetricType enum values #29066

Merged
merged 7 commits into from
Mar 1, 2024

Conversation

msambol
Copy link
Contributor

@msambol msambol commented Feb 11, 2024

There are three PredefinedMetricType values missing from the enum:

  • SageMakerVariantProvisionedConcurrencyUtilization
  • SageMakerInferenceComponentInvocationsPerCopy
  • ElastiCacheDatabaseCapacityUsageCountedForEvictPercentage

https://docs.aws.amazon.com/autoscaling/application/APIReference/API_PredefinedMetricSpecification.html

Closes #29065.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@github-actions github-actions bot added feature-request A feature should be added or improved. p2 labels Feb 11, 2024
@aws-cdk-automation aws-cdk-automation requested a review from a team February 11, 2024 01:11
@github-actions github-actions bot added the star-contributor [Pilot] contributed between 25-49 PRs to the CDK label Feb 11, 2024
@msambol
Copy link
Contributor Author

msambol commented Feb 11, 2024

Exemption request: I don't think integration is needed here? Just adding a new enum value.

@aws-cdk-automation aws-cdk-automation added the pr-linter/exemption-requested The contributor has requested an exemption to the PR Linter feedback. label Feb 11, 2024
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

@msambol msambol changed the title feat(applicationautoscaling): add sagemaker variant scaling policy feat(applicationautoscaling): PredefinedMetricType values Feb 11, 2024
@aws-cdk-automation aws-cdk-automation added the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Feb 11, 2024
@aws-cdk-automation aws-cdk-automation added pr/needs-maintainer-review This PR needs a review from a Core Team Member and removed pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. labels Feb 25, 2024
@paulhcsun paulhcsun added the pr-linter/exempt-integ-test The PR linter will not require integ test changes label Mar 1, 2024
@paulhcsun paulhcsun changed the title feat(applicationautoscaling): PredefinedMetricType values feat(applicationautoscaling): add missing PredefinedMetricType enum values Mar 1, 2024
@github-actions github-actions bot added the effort/medium Medium work item – several days of effort label Mar 1, 2024
@aws-cdk-automation aws-cdk-automation dismissed their stale review March 1, 2024 00:36

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: d173b6d
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

Copy link
Contributor

mergify bot commented Mar 1, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit 63390e1 into aws:main Mar 1, 2024
10 checks passed
@msambol msambol deleted the 29065 branch March 1, 2024 02:08
@aws-cdk-automation aws-cdk-automation removed the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Mar 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
effort/medium Medium work item – several days of effort feature-request A feature should be added or improved. p2 pr-linter/exempt-integ-test The PR linter will not require integ test changes pr-linter/exemption-requested The contributor has requested an exemption to the PR Linter feedback. star-contributor [Pilot] contributed between 25-49 PRs to the CDK
Projects
None yet
Development

Successfully merging this pull request may close these issues.

aws_applicationautoscaling: Enable SageMaker serverless provisioned concurrency utilization predefined metric
4 participants