Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(defaultStackSynthesizer): prevent App level synthesizer from propagating assets across stacks #29073

Closed
wants to merge 5 commits into from

Conversation

castodius
Copy link

Issue 29071
Closes #29071

Reason for this change
The method reusableBind on DefaultStackSynthesizer which is intended to copy the current DefaultStackSynthesizer ends up returning an instance with a reference to the AssetManifestBuilder instance. All stacks end up sharing the same asset manager and additional assets end up in the wrong stacks.

Description of changes
The method reusableBind now instantiates a new AssetManifestBuild eliminating the problem.

Description of how you validated changes
I have added a unit test which fails if my changes are not included. In addition I took the questionable cowboy approach of verifying the code change by changing minified code for default-stack-synthesizer.ts in a test project.

Checklist
[ x ] My code adheres to the CONTRIBUTING GUIDE and DESIGN GUIDELINES

@github-actions github-actions bot added beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK bug This issue is a bug. p2 labels Feb 11, 2024
@aws-cdk-automation aws-cdk-automation requested a review from a team February 11, 2024 20:37
@castodius
Copy link
Author

I was not sure where to place the unit test, so I simply placed it under the only describe available. Perhaps it belongs in a new describe together with this test specifically for "app level synthesizer".

Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

@castodius castodius changed the title Prevent App level DefaultStackSynthesizer from propagating assets across stacks fix(DefaultStackSynthesizer): Prevent App level synthesizer from propagating assets across stacks Feb 11, 2024
@castodius castodius changed the title fix(DefaultStackSynthesizer): Prevent App level synthesizer from propagating assets across stacks feat(defaultStackSynthesizer): Prevent App level synthesizer from propagating assets across stacks Feb 11, 2024
@castodius castodius changed the title feat(defaultStackSynthesizer): Prevent App level synthesizer from propagating assets across stacks chore(defaultStackSynthesizer): prevent App level synthesizer from propagating assets across stacks Feb 11, 2024
@aws-cdk-automation aws-cdk-automation dismissed their stale review February 11, 2024 20:49

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

@aws-cdk-automation aws-cdk-automation added the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Feb 11, 2024
@castodius castodius changed the title chore(defaultStackSynthesizer): prevent App level synthesizer from propagating assets across stacks fix(defaultStackSynthesizer): prevent App level synthesizer from propagating assets across stacks Feb 27, 2024
@github-actions github-actions bot added the effort/medium Medium work item – several days of effort label Feb 27, 2024
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

@aws-cdk-automation aws-cdk-automation removed the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Feb 27, 2024
@aws-cdk-automation
Copy link
Collaborator

This PR has been in the CHANGES REQUESTED state for 3 weeks, and looks abandoned. To keep this PR from being closed, please continue work on it. If not, it will automatically be closed in a week.

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 3388e94
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@aws-cdk-automation
Copy link
Collaborator

This PR has been deemed to be abandoned, and will be automatically closed. Please create a new PR for these changes if you think this decision has been made in error.

@aws-cdk-automation aws-cdk-automation added the closed-for-staleness This issue was automatically closed because it hadn't received any attention in a while. label Mar 27, 2024
@aws-cdk-automation
Copy link
Collaborator

The pull request linter fails with the following errors:

❌ Fixes must contain a change to an integration test file and the resulting snapshot.

PRs must pass status checks before we can provide a meaningful review.

If you would like to request an exemption from the status checks or clarification on feedback, please leave a comment on this PR containing Exemption Request and/or Clarification Request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK bug This issue is a bug. closed-for-staleness This issue was automatically closed because it hadn't received any attention in a while. effort/medium Medium work item – several days of effort p2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DefaultStackSynthesizer: App level synthesizer leaks assets between Stacks when specified
2 participants