-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(defaultStackSynthesizer): prevent App level synthesizer from propagating assets across stacks #29073
Conversation
I was not sure where to place the unit test, so I simply placed it under the only describe available. Perhaps it belongs in a new describe together with this test specifically for "app level synthesizer". |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.
A comment requesting an exemption should contain the text Exemption Request
. Additionally, if clarification is needed add Clarification Request
to a comment.
✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.
A comment requesting an exemption should contain the text Exemption Request
. Additionally, if clarification is needed add Clarification Request
to a comment.
This PR has been in the CHANGES REQUESTED state for 3 weeks, and looks abandoned. To keep this PR from being closed, please continue work on it. If not, it will automatically be closed in a week. |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
This PR has been deemed to be abandoned, and will be automatically closed. Please create a new PR for these changes if you think this decision has been made in error. |
The pull request linter fails with the following errors:
PRs must pass status checks before we can provide a meaningful review. If you would like to request an exemption from the status checks or clarification on feedback, please leave a comment on this PR containing |
Issue 29071
Closes #29071
Reason for this change
The method reusableBind on DefaultStackSynthesizer which is intended to copy the current DefaultStackSynthesizer ends up returning an instance with a reference to the AssetManifestBuilder instance. All stacks end up sharing the same asset manager and additional assets end up in the wrong stacks.
Description of changes
The method reusableBind now instantiates a new AssetManifestBuild eliminating the problem.
Description of how you validated changes
I have added a unit test which fails if my changes are not included. In addition I took the questionable cowboy approach of verifying the code change by changing minified code for default-stack-synthesizer.ts in a test project.
Checklist
[ x ] My code adheres to the CONTRIBUTING GUIDE and DESIGN GUIDELINES