fix(sqs): redrivePermission is set to byQueue no matter what value is specified

[yoshi-d-24]

Issue #29129

Closes #29129.

Reason for this change

When redriveAllowPolicy.redrivePermission is specified, any value will be output to template as byQueue

Description of changes

1. Fix the evaluation order by enclosing the ternary operators in parentheses

        ?? (props.redriveAllowPolicy.sourceQueues ? RedrivePermission.BY_QUEUE : RedrivePermission.ALLOW_ALL),

2. Added a test case in packages/aws-cdk-lib/aws-sqs/test/sqs.test.ts when redrivePermission is specified other than BY_QUEUE.
3. Added an integ test case in packages/@aws-cdk-testing/framework-integ/test/aws-sqs/test/integ.sqs-source-queue-permission.ts

Description of how you validated changes

Added a test case in packages/aws-cdk-lib/aws-sqs/test/sqs.test.ts when redrivePermission is specified other than BY_QUEUE.
Added an integ test case in packages/@aws-cdk-testing/framework-integ/test/aws-sqs/test/integ.sqs-source-queue-permission.ts
And ran the test case.

Checklist

• My code adheres to the CONTRIBUTING GUIDE and DESIGN GUIDELINES

---

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

[aws-cdk-automation]

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

[go-to-k]

Thanks for this PR. Looks good, but I made one minor comment.

[go-to-k]

Might be better with test.each.

Suggested change

	test('explicit specification of redrive permission', () => {
	const stack = new Stack();
	new sqs.Queue(stack, 'Queue', {
	redriveAllowPolicy: {
	redrivePermission: sqs.RedrivePermission.DENY_ALL,
	},
	});
	Template.fromStack(stack).templateMatches({
	'Resources': {
	'Queue4A7E3555': {
	'Type': 'AWS::SQS::Queue',
	'Properties': {
	'RedriveAllowPolicy': {
	'redrivePermission': 'denyAll',
	},
	},
	'UpdateReplacePolicy': 'Delete',
	'DeletionPolicy': 'Delete',
	},
	},
	});
	});
	test.each([
	[sqs.RedrivePermission.ALLOW_ALL, 'allowAll'],
	[sqs.RedrivePermission.DENY_ALL, 'denyAll'],
	])('redrive permission can be set to %s', (permission, expected) => {
	const stack = new Stack();
	new sqs.Queue(stack, 'Queue', {
	redriveAllowPolicy: {
	redrivePermission: permission,
	},
	});
	Template.fromStack(stack).templateMatches({
	'Resources': {
	'Queue4A7E3555': {
	'Type': 'AWS::SQS::Queue',
	'Properties': {
	'RedriveAllowPolicy': {
	'redrivePermission': expected,
	},
	},
	'UpdateReplacePolicy': 'Delete',
	'DeletionPolicy': 'Delete',
	},
	},
	});
	});

[go-to-k]

And a better title for the PR would be something like fix(sqs): `redrivePermission` is set to `byQueue` no matter what value is specified. This is because a fix PR should indicate what kind of bug it is, not how it was fixed.

[yoshi-d-24]

@go-to-k
Updated as you pointed out. Thank you.

[go-to-k]

Thanks.

[kaizencc]

Thanks for the fix @yoshi-d-24

[mergify]

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

[mergify]

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

Pull request has been modified.

[yoshi-d-24]

@kaizencc
Sorry, I accidentally pushed Update Branch button and merged main.
Can you please review it again?

[mergify]

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

[mergify]

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

Pull request has been modified.

[mergify]

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

[aws-cdk-automation]

AWS CodeBuild CI Report

• CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
• Commit ID: a6d16ef
• Result: SUCCEEDED
• Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

[mergify]

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).