-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(integ-test-alpha): add log group retention days to integ test stack #29277
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would prefer that we make this a configurable field rather than just assigning an arbitrary time period.
packages/@aws-cdk/integ-tests-alpha/lib/assertions/providers/provider.ts
Show resolved
Hide resolved
packages/@aws-cdk/integ-tests-alpha/lib/assertions/providers/provider.ts
Outdated
Show resolved
Hide resolved
@Mergifyio update |
✅ Branch has been successfully updated |
Dismissing as the feedback is addressed
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
This PR has a bug that if you use this feature then you cannot have more than 1 long running assertion stack co-exist in the same aws account. It's common to have shared aws accounts, and this feature uses the hardcoded singleton uuid value with id then used for the log group I'm not sure yet if there is a way to circumvent this and get to override the uuid that is baked in here that results in part of the singleton functions's id 😢 I'll work on writing up a proper bug issue when I have a moment |
Issue # (if applicable)
Closes #29260
Reason for this change
CloudWatch log groups created by the integ tests are set to never expire, so end up cluttering up your aws account and need manual cleanup.
Description of changes
Added custom log group with log group retention
Description of how you validated changes
All existing tests and new tests pass.
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license