-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(stepfunctions-tasks): start build batch integration #29296
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.
A comment requesting an exemption should contain the text Exemption Request
. Additionally, if clarification is needed add Clarification Request
to a comment.
✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.
3f45609
to
da7c40b
Compare
dff4755
to
32e3f7a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good 👍
I left some suggestions for cleaning up the documentation.
packages/aws-cdk-lib/aws-stepfunctions-tasks/lib/codebuild/start-build-batch.ts
Outdated
Show resolved
Hide resolved
packages/aws-cdk-lib/aws-stepfunctions-tasks/lib/codebuild/start-build-batch.ts
Outdated
Show resolved
Hide resolved
packages/aws-cdk-lib/aws-stepfunctions-tasks/lib/codebuild/start-build-batch.ts
Outdated
Show resolved
Hide resolved
packages/aws-cdk-lib/aws-stepfunctions-tasks/test/codebuild/start-build-batch.test.ts
Outdated
Show resolved
Hide resolved
Co-authored-by: Luca Pizzini <lpizzini7@gmail.com>
Co-authored-by: Luca Pizzini <lpizzini7@gmail.com>
Co-authored-by: Luca Pizzini <lpizzini7@gmail.com>
Co-authored-by: Luca Pizzini <lpizzini7@gmail.com>
Co-authored-by: Luca Pizzini <lpizzini7@gmail.com>
Co-authored-by: Luca Pizzini <lpizzini7@gmail.com>
@lpizzinidev Thank you for your review!! I've addressed your comment. |
}, | ||
}), | ||
}); | ||
project.enableBatchBuilds(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you please add a note below explaining the scenarios when enableBatchBuilds()
returns undefined
?
Eg:
**Note**: Batch builds are not supported for ...
You can verify if batch builds are enabled by checking `enableBatchBuilds()` returned value:
```ts
const enabled = project.enableBatchBuilds();
if (enabled === undefined) {
throw new Error('Batch build were not enabled');
}
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have added only Notes.
The enableBatchBuilds()
returns undefined
exclusively for imported projects, and this return value persists regardless of the batch build's actual status (enabled or not) within those projects. Consequently, users working with imported projects must manually ensure that batch builds are enabled, as relying on the return value of enableBatchBuilds()
is not informative.
I believe it suffices to include this as a note without detailing the process of verifying the return value of enableBatchBuilds()
.
What do you think about that?
I'm sorry for my initial README desciption confused you...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the detailed clarification 👍
@lpizzinidev Thanks!! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @badmintoncryer for the PR and @lpizzinidev for the detailed review. The changes look good. Happy to approve it.
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Issue # (if applicable)
Closes #29119.
Reason for this change
There is an optimized integration with codebuild but it is not able to integrate by AWS CDK.
Description of changes
Add CodeBuildStartBuildBatch class
Description of how you validated changes
I've implemented both unit and integ tests.
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license