Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(fix) MaxConcurrency does not support JsonPath #29317

Closed
wants to merge 1 commit into from

Conversation

abdelnn
Copy link
Contributor

@abdelnn abdelnn commented Feb 29, 2024

Issue # (if applicable)

Relates to #20835

Reason for this change

MaxConcurrency does not support JsonPath. This change adds MaxConcurrencyPath so that CDK users can specify a JsonPath for their MaxConcurrency

Note : This does not invalidate JsonPaths for MaxConcurrency, as I'm unsure how to do so without reverting #20279 . Open to suggestions

Description of changes

Added a new maxConcurrencyPath field that accepts a JsonPath value. Decided to go with another explicit field as it is similar to what is done for ErrorPath and CausePath, in addition to most other Path fields

Description of how you validated changes

Added unit tests

Checklist


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@github-actions github-actions bot added beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK p2 labels Feb 29, 2024
@aws-cdk-automation aws-cdk-automation requested a review from a team February 29, 2024 19:45
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

@aws-cdk-automation
Copy link
Collaborator

The pull request linter fails with the following errors:

❌ The title of this pull request does not follow the Conventional Commits format, see https://www.conventionalcommits.org/.

PRs must pass status checks before we can provide a meaningful review.

If you would like to request an exemption from the status checks or clarification on feedback, please leave a comment on this PR containing Exemption Request and/or Clarification Request.

@abdelnn abdelnn closed this Feb 29, 2024
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 1337cdf
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@abdelnn abdelnn deleted the maxConcurrencyPath branch April 23, 2024 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK p2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants